third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp - Issue 2886893008: [DMC #8] Rename DocumentMarkerController::RenderedRectsForMarkers()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

Issue 2886893008: [DMC #8] Rename DocumentMarkerController::RenderedRectsForMarkers() (Closed)

Patch Set: Reformat FrameView Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

index 42d545a4b645ef0c9cec2631297ad643a7bdd820..7e2b526ff7ea4a6685731c31760a880ce0f86b95 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

@@ -205,13 +205,13 @@ TEST_F(DocumentMarkerControllerTest, UpdateRenderedRects) {

Element* div = ToElement(GetDocument().body()->firstChild());

MarkNodeContentsTextMatch(div);

Vector<IntRect> rendered_rects =

- MarkerController().RenderedRectsForMarkers(DocumentMarker::kTextMatch);

+ MarkerController().RenderedRectsForTextMatchMarkers();

EXPECT_EQ(1u, rendered_rects.size());

div->setAttribute(HTMLNames::styleAttr, "margin: 200px");

GetDocument().UpdateStyleAndLayout();

Vector<IntRect> new_rendered_rects =

- MarkerController().RenderedRectsForMarkers(DocumentMarker::kTextMatch);

+ MarkerController().RenderedRectsForTextMatchMarkers();

EXPECT_EQ(1u, new_rendered_rects.size());

EXPECT_NE(rendered_rects[0], new_rendered_rects[0]);

}