Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2886653002: Removed dependency of ExternalDateTimeChooser on ChromeClientImpl (Closed)

Created:
3 years, 7 months ago by sashab
Modified:
3 years, 7 months ago
Reviewers:
slangley, dcheng
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed dependency of ExternalDateTimeChooser on ChromeClientImpl BUG=712963 Review-Url: https://codereview.chromium.org/2886653002 Cr-Commit-Position: refs/heads/master@{#472768} Committed: https://chromium.googlesource.com/chromium/src/+/50d38ea52935abf060b3b7b6b9fb83bc7d1abc1e

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/web/ExternalDateTimeChooser.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 22 (16 generated)
sashab
3 years, 7 months ago (2017-05-16 02:59:08 UTC) #3
slangley
lgtm
3 years, 7 months ago (2017-05-16 03:38:37 UTC) #5
sashab
3 years, 7 months ago (2017-05-16 03:40:14 UTC) #7
dcheng
LGTM
3 years, 7 months ago (2017-05-16 03:52:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886653002/40001
3 years, 7 months ago (2017-05-18 11:32:43 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 11:38:56 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/50d38ea52935abf060b3b7b6b9fb...

Powered by Google App Engine
This is Rietveld 408576698