Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2884803004: Removed dependency of PopupMenuImpl on ChromeClientImpl (Closed)

Created:
3 years, 7 months ago by sashab
Modified:
3 years, 7 months ago
Reviewers:
slangley, dcheng
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed dependency of PopupMenuImpl on ChromeClientImpl BUG=712963 Review-Url: https://codereview.chromium.org/2884803004 Cr-Commit-Position: refs/heads/master@{#472764} Committed: https://chromium.googlesource.com/chromium/src/+/f14848339fac1c011fa60315db1859f67cd49818

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/web/PopupMenuImpl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (14 generated)
sashab
3 years, 7 months ago (2017-05-16 01:27:48 UTC) #3
slangley
lgtm
3 years, 7 months ago (2017-05-16 01:35:37 UTC) #5
sashab
3 years, 7 months ago (2017-05-16 01:37:36 UTC) #7
dcheng
LGTM
3 years, 7 months ago (2017-05-16 02:28:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884803004/20001
3 years, 7 months ago (2017-05-16 03:41:33 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/455436)
3 years, 7 months ago (2017-05-16 05:19:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884803004/40001
3 years, 7 months ago (2017-05-18 09:35:32 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 11:20:11 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f14848339fac1c011fa60315db18...

Powered by Google App Engine
This is Rietveld 408576698