Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2883143004: Removed dependency of InspectorOverlayAgent on ChromeClientImpl (Closed)

Created:
3 years, 7 months ago by sashab
Modified:
3 years, 7 months ago
Reviewers:
slangley, dcheng
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed dependency of InspectorOverlayAgent on ChromeClientImpl BUG=712963 Review-Url: https://codereview.chromium.org/2883143004 Cr-Commit-Position: refs/heads/master@{#473502} Committed: https://chromium.googlesource.com/chromium/src/+/8f1deb4a7aa0e11a6db80bd3127493a5d3bd607c

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlayAgent.cpp View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
sashab
3 years, 7 months ago (2017-05-16 03:54:03 UTC) #2
slangley
lgtm
3 years, 7 months ago (2017-05-16 04:14:21 UTC) #3
sashab
3 years, 7 months ago (2017-05-16 04:30:47 UTC) #5
dcheng
lgtm
3 years, 7 months ago (2017-05-16 09:02:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883143004/20001
3 years, 7 months ago (2017-05-18 11:47:15 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448441)
3 years, 7 months ago (2017-05-18 15:34:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883143004/40001
3 years, 7 months ago (2017-05-22 02:30:36 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 04:17:25 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8f1deb4a7aa0e11a6db80bd31274...

Powered by Google App Engine
This is Rietveld 408576698