Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2886623002: Revert of Reland: Handle long press in PDF documents. (Closed)

Created:
3 years, 7 months ago by afakhry
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Handle long press in PDF documents. (patchset #4 id:60001 of https://codereview.chromium.org/2861383003/ ) Reason for revert: Causes failure in browser_tests on the Linux ChromiumOS Tests builder (PDFExtensionTest.TouchHandling). BUG=722625 Original issue's description: > Reland: Handle long press in PDF documents. > > This Cl updates the touch handlers for PDF documents to better support > long press. The long press context menu is suppressed and the wonder > under the press is of sufficient time. > > BUG=chromium:490184 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > PRIOR REVIEWS: > > Review-Url: https://codereview.chromium.org/2855953003 > > Revert Review-Url: https://codereview.chromium.org/2864603006 > > Review-Url: https://codereview.chromium.org/2861383003 > Cr-Commit-Position: refs/heads/master@{#471915} > Committed: https://chromium.googlesource.com/chromium/src/+/c40173af073adb3b81cc4de1e8e8467b48b384df TBR=thestig@chromium.org,mcnee@chromium.org,dsinclair@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:490184 Review-Url: https://codereview.chromium.org/2886623002 Cr-Commit-Position: refs/heads/master@{#471951} Committed: https://chromium.googlesource.com/chromium/src/+/efe1452454a46b9926b8298e318f83042c11ff19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -288 lines) Patch
M chrome/browser/pdf/pdf_extension_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/pdf/gesture_detector.js View 3 chunks +8 lines, -19 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/test/data/pdf/gesture_detector_test.js View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/test/data/pdf/touch_handling_test.js View 1 chunk +0 lines, -73 lines 0 comments Download
M pdf/out_of_process_instance.h View 3 chunks +0 lines, -4 lines 0 comments Download
M pdf/out_of_process_instance.cc View 7 chunks +26 lines, -53 lines 0 comments Download
M pdf/pdf_engine.h View 2 chunks +2 lines, -7 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 4 chunks +7 lines, -12 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 6 chunks +9 lines, -61 lines 0 comments Download
M pdf/preview_mode_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M pdf/preview_mode_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
afakhry
Created Revert of Reland: Handle long press in PDF documents.
3 years, 7 months ago (2017-05-15 23:56:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886623002/1
3 years, 7 months ago (2017-05-15 23:57:39 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 23:58:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/efe1452454a46b9926b8298e318f...

Powered by Google App Engine
This is Rietveld 408576698