Multiselectable touchups for ARIA widgets

Multiselectable touchups for ARIA widgets

BUG=723795
Review-Url: https://codereview.chromium.org/2886243002
Cr-Commit-Position: refs/heads/master@{#473368}
Committed: https://chromium.googlesource.com/chromium/src/+/f1d7f62ed596312a3e0bb1c3677a4a1ccbd8030d

[aleventhal, 2017-05-17 19:39:58]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 19:41:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 20:53:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:53:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aleventhal, 2017-05-17 21:06:30]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 21:07:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 22:11:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 22:11:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aleventhal, 2017-05-18 14:14:27]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 14:14:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 14:18:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 14:18:41]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aleventhal, 2017-05-18 16:09:25]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 16:10:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-05-18 19:21:20]

Description was changed from

==========
Multiselectable touchups for ARIA widgets

BUG=723795
==========

to

==========
Multiselectable touchups for ARIA widgets

BUG=723795
==========

[aleventhal, 2017-05-18 19:21:20]

aleventhal@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[aleventhal, 2017-05-18 19:22:03]

Ready for review

[commit-bot: I haz the power, 2017-05-18 20:01:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 20:01:40]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dmazzoni, 2017-05-19 19:40:56]

lgtm with one fix for Android

https://codereview.chromium.org/2886243002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2886243002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:1062: return
isHTMLSelectElement(GetNode()) &&
I'm not sure this covers all of the possible roles for
a <select multiple>. In particular on Android I think
a <select multiple> appears as a pop-up button (just
like a regular <select>) and when you click on it, it
pops up a list with items you can check.

I'd put this out of the switch.

[aleventhal, 2017-05-19 19:51:49]

The CQ bit was checked by aleventhal@chromium.org

[aleventhal, 2017-05-19 19:51:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2886243002/#ps80001
(title: "Address review")

[commit-bot: I haz the power, 2017-05-19 19:52:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 22:33:56]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495223509460550,
"parent_rev": "e9cc6305714c1a585bc5cf51d289fdf000070ea0", "commit_rev":
"f1d7f62ed596312a3e0bb1c3677a4a1ccbd8030d"}

[commit-bot: I haz the power, 2017-05-19 22:34:12]

Description was changed from

==========
Multiselectable touchups for ARIA widgets

BUG=723795
==========

to

==========
Multiselectable touchups for ARIA widgets

BUG=723795

Review-Url: https://codereview.chromium.org/2886243002
Cr-Commit-Position: refs/heads/master@{#473368}
Committed:
https://chromium.googlesource.com/chromium/src/+/f1d7f62ed596312a3e0bb1c3677a...
==========

[commit-bot: I haz the power, 2017-05-19 22:34:13]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f1d7f62ed596312a3e0bb1c3677a...