Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(43)

Issue 2886243002: Multiselectable touchups for ARIA widgets (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by aleventhal
Modified:
1 month, 1 week ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, nektarios, je_julie, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Multiselectable touchups for ARIA widgets BUG=723795 Review-Url: https://codereview.chromium.org/2886243002 Cr-Commit-Position: refs/heads/master@{#473368} Committed: https://chromium.googlesource.com/chromium/src/+/f1d7f62ed596312a3e0bb1c3677a4a1ccbd8030d

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Fix tests #

Patch Set 4 : Fix tests #

Total comments: 1

Patch Set 5 : Address review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -8 lines) Patch
M content/test/data/accessibility/aria/aria-grid-expected-win.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-gridcell.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-rowheader-expected-win.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/accessibility/aria-multiselect-state.html View 1 chunk +83 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 2 3 4 1 chunk +14 lines, -4 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 26 (22 generated)
aleventhal
Ready for review
1 month, 1 week ago (2017-05-18 19:22:03 UTC) #17
dmazzoni
lgtm with one fix for Android https://codereview.chromium.org/2886243002/diff/60001/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right): https://codereview.chromium.org/2886243002/diff/60001/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp#newcode1062 third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:1062: return isHTMLSelectElement(GetNode()) && ...
1 month, 1 week ago (2017-05-19 19:40:56 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886243002/80001
1 month, 1 week ago (2017-05-19 19:52:24 UTC) #23
commit-bot: I haz the power
1 month, 1 week ago (2017-05-19 22:34:13 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f1d7f62ed596312a3e0bb1c3677a...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318