Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Issue 2886243002: Multiselectable touchups for ARIA widgets (Closed)
Patch Set: Address review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
index 236cd2a75507caac6b60a0d39cdfb15fc718853a..dda213c67ef639fa74899d35e342153145c14f17 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
@@ -1047,10 +1047,20 @@ bool AXNodeObject::IsMeter() const {
}
bool AXNodeObject::IsMultiSelectable() const {
- bool multiselectable = false;
- if (HasAOMPropertyOrARIAAttribute(AOMBooleanProperty::kMultiselectable,
- multiselectable)) {
- return multiselectable;
+ switch (RoleValue()) {
+ case kGridRole:
+ case kTreeGridRole:
+ case kTreeRole:
+ case kListBoxRole:
+ case kTabListRole: {
+ bool multiselectable = false;
+ if (HasAOMPropertyOrARIAAttribute(AOMBooleanProperty::kMultiselectable,
+ multiselectable)) {
+ return multiselectable;
+ }
+ }
+ default:
+ break;
}
return isHTMLSelectElement(GetNode()) &&
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698