Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(131)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: content/test/data/accessibility/aria/aria-gridcell.html
Issue
2886243002
:
Multiselectable touchups for ARIA widgets (Closed)
Patch Set: Address review
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
content/test/data/accessibility/aria/aria-grid-expected-win.txt
content/test/data/accessibility/aria/aria-gridcell.html
content/test/data/accessibility/aria/aria-rowheader-expected-win.txt
third_party/WebKit/LayoutTests/accessibility/aria-multiselect-state.html
third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« content/test/data/accessibility/aria/aria-grid-expected-win.txt
('k') |
content/test/data/accessibility/aria/aria-rowheader-expected-win.txt »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 <!--
1 <!--
2 @MAC-ALLOW:AXRole*
2 @MAC-ALLOW:AXRole*
3 @WIN-ALLOW:*SELECTABLE
3 @WIN-ALLOW:*SELECTABLE
4 @WIN-ALLOW:xml-roles*
4 @WIN-ALLOW:xml-roles*
5 -->
5 -->
6 <!DOCTYPE html>
6 <!DOCTYPE html>
7 <html>
7 <html>
8 <body>
8 <body>
9
<div role="grid">
9
<div role="grid"
aria-multiselectable="true"
>
10 <div role="row">
10 <div role="row">
11 <span role="columnheader">Browser</span>
11 <span role="columnheader">Browser</span>
12 <span role="columnheader">Rendering Engine</span>
12 <span role="columnheader">Rendering Engine</span>
13 </div>
13 </div>
14 <div role="row">
14 <div role="row">
15 <span role="gridcell">Chrome</span>
15 <span role="gridcell">Chrome</span>
16 <span role="gridcell">Blink</span>
16 <span role="gridcell">Blink</span>
17 </div>
17 </div>
18 </div>
18 </div>
19 </body>
19 </body>
20 </html>
20 </html>
OLD
NEW
« no previous file with comments
|
« content/test/data/accessibility/aria/aria-grid-expected-win.txt
('k') |
content/test/data/accessibility/aria/aria-rowheader-expected-win.txt »
('j') |
no next file with comments »
Issue 2886243002: Multiselectable touchups for ARIA widgets (Closed)
Created 3 years, 7 months ago by aleventhal
Modified 3 years, 7 months ago
Reviewers: dmazzoni
Base URL:
Comments: 1
This is Rietveld
408576698
Chromium Code Reviews
Issue 2886243002:
Multiselectable touchups for ARIA widgets (Closed)
