Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2886083003: Merge "cros: Hide banner on NeedsDircryptoMigration call failure" (Closed)

Created:
3 years, 7 months ago by xiyuan
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge "cros: Hide banner on NeedsDircryptoMigration call failure" > NeedsDircryptoMigration call fails when user cryptohome is removed. > Leaving banner status unchanged is confusing. Hide the banner when > this happens to make UI consistent. > > BUG=721948 > > Review-Url: https://codereview.chromium.org/2879333002 > Cr-Commit-Position: refs/heads/master@{#471928} > (cherry picked from commit ecfbc2ccd1072ed4f01a4a9c902fc5be9ed458a4) Review-Url: https://codereview.chromium.org/2886083003 . Cr-Commit-Position: refs/branch-heads/3071@{#598} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/29f07c0bcb088e515f8f252bb10c2e4e9bfa4a80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xiyuan
3 years, 7 months ago (2017-05-17 16:16:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29f07c0bcb088e515f8f252bb10c2e4e9bfa4a80.

Powered by Google App Engine
This is Rietveld 408576698