Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3742)

Unified Diff: chrome/browser/chromeos/login/screens/user_selection_screen.cc

Issue 2886083003: Merge "cros: Hide banner on NeedsDircryptoMigration call failure" (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/screens/user_selection_screen.cc
diff --git a/chrome/browser/chromeos/login/screens/user_selection_screen.cc b/chrome/browser/chromeos/login/screens/user_selection_screen.cc
index a3416bf6321f85bb53544de73f9e9181c9df93ae..aef9766aca8197d4b31eaca774483f3f2ca09f2c 100644
--- a/chrome/browser/chromeos/login/screens/user_selection_screen.cc
+++ b/chrome/browser/chromeos/login/screens/user_selection_screen.cc
@@ -200,6 +200,9 @@ class UserSelectionScreen::DircryptoMigrationChecker {
bool needs_migration) {
if (call_status != DBUS_METHOD_CALL_SUCCESS) {
LOG(ERROR) << "Failed to call cryptohome NeedsDircryptoMigration.";
+ // Hide the banner to avoid confusion in http://crbug.com/721948.
+ // Cache is not updated so that cryptohome call will still be attempted.
+ UpdateUI(account_id, false);
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698