cros: Hide banner on NeedsDircryptoMigration call failure

cros: Hide banner on NeedsDircryptoMigration call failure

NeedsDircryptoMigration call fails when user cryptohome is removed.
Leaving banner status unchanged is confusing. Hide the banner when
this happens to make UI consistent.

BUG=721948
Review-Url: https://codereview.chromium.org/2879333002
Cr-Commit-Position: refs/heads/master@{#471928}
Committed: https://chromium.googlesource.com/chromium/src/+/ecfbc2ccd1072ed4f01a4a9c902fc5be9ed458a4

[xiyuan, 2017-05-15 18:10:53]

xiyuan@chromium.org changed reviewers:
+ achuith@chromium.org

[xiyuan, 2017-05-15 18:10:54]

PTAL. Thanks.

[xiyuan, 2017-05-15 18:10:58]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 18:11:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 18:50:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 18:50:39]

Dry run: This issue passed the CQ dry run.

[achuithb, 2017-05-15 21:33:38]

lgtm.

We're just hiding the banner for cryptohomes that have been reaped, is that
right?

https://codereview.chromium.org/2879333002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/user_selection_screen.cc (right):

https://codereview.chromium.org/2879333002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_selection_screen.cc:203: // Hide the
banner to avoid confusions in http://crbug.com/721948.
s/confusions/confusion

[xiyuan, 2017-05-15 21:39:00]

Correct. Those users would not see the migration UI since they will have
cryptohome re-created and that would be created in the new format. So no banners
for them.

https://codereview.chromium.org/2879333002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/user_selection_screen.cc (right):

https://codereview.chromium.org/2879333002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_selection_screen.cc:203: // Hide the
banner to avoid confusions in http://crbug.com/721948.
On 2017/05/15 21:33:38, achuithb wrote:
> s/confusions/confusion

Done.

[xiyuan, 2017-05-15 21:40:42]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2017-05-15 21:40:42]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2879333002/#ps20001
(title: "fix nit")

[commit-bot: I haz the power, 2017-05-15 21:42:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 22:35:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494884442271870,
"parent_rev": "f9c42e188b9b4d4333b25ca75a7666c28695fce4", "commit_rev":
"ecfbc2ccd1072ed4f01a4a9c902fc5be9ed458a4"}

[commit-bot: I haz the power, 2017-05-15 22:35:39]

Description was changed from

==========
cros: Hide banner on NeedsDircryptoMigration call failure

NeedsDircryptoMigration call fails when user cryptohome is removed.
Leaving banner status unchanged is confusing. Hide the banner when
this happens to make UI consistent.

BUG=721948
==========

to

==========
cros: Hide banner on NeedsDircryptoMigration call failure

NeedsDircryptoMigration call fails when user cryptohome is removed.
Leaving banner status unchanged is confusing. Hide the banner when
this happens to make UI consistent.

BUG=721948

Review-Url: https://codereview.chromium.org/2879333002
Cr-Commit-Position: refs/heads/master@{#471928}
Committed:
https://chromium.googlesource.com/chromium/src/+/ecfbc2ccd1072ed4f01a4a9c902f...
==========

[commit-bot: I haz the power, 2017-05-15 22:35:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ecfbc2ccd1072ed4f01a4a9c902f...