DevTools: prep audits panel for Lighthouse roll

DevTools: prep audits panel for Lighthouse roll

* Adds lh-devtools class to report container
* Removes devtools filmstrip now that it has been upstreamed to Lighthouse
* Changes AuditService to return an object containing the error message instead of null 

R=paulirish,pfeldman

Review-Url: https://codereview.chromium.org/2886073002
Cr-Commit-Position: refs/heads/master@{#472640}
Committed: https://chromium.googlesource.com/chromium/src/+/1846d7354ae835630ac31c6adf091e0e8cdaa54b

[phulce, 2017-05-17 21:46:53]

Description was changed from

==========
DevTools: prep audits panel for Lighthouse roll

R=paulirish,pfeldman
==========

to

==========
DevTools: prep audits panel for Lighthouse roll

* Removes devtools filmstrip now that it has been upstreamed to Lighthouse
* Changes AuditService to return an object containing the error message instead
of null 

R=paulirish,pfeldman
==========

[phulce, 2017-05-17 21:47:18]

Description was changed from

==========
DevTools: prep audits panel for Lighthouse roll

* Removes devtools filmstrip now that it has been upstreamed to Lighthouse
* Changes AuditService to return an object containing the error message instead
of null 

R=paulirish,pfeldman
==========

to

==========
DevTools: prep audits panel for Lighthouse roll

* Adds lh-devtools class to report container
* Removes devtools filmstrip now that it has been upstreamed to Lighthouse
* Changes AuditService to return an object containing the error message instead
of null 

R=paulirish,pfeldman
==========

[pfeldman, 2017-05-17 22:57:27]

lgtm

[paulirish, 2017-05-17 23:08:19]

https://codereview.chromium.org/2886073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2886073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:159: if
(lighthouseResult && lighthouseResult.failed) {
fatal

https://codereview.chromium.org/2886073002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
(right):

https://codereview.chromium.org/2886073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js:62:
stack: err.stack,
add userAgent and initialUrl

[phulce, 2017-05-17 23:44:13]

https://codereview.chromium.org/2886073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2886073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:159: if
(lighthouseResult && lighthouseResult.failed) {
On 2017/05/17 23:08:19, paulirish wrote:
> fatal

Done.

https://codereview.chromium.org/2886073002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
(right):

https://codereview.chromium.org/2886073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js:62:
stack: err.stack,
On 2017/05/17 23:08:19, paulirish wrote:
> add userAgent and initialUrl 

Done.

[paulirish, 2017-05-17 23:58:55]

lgtm

[paulirish, 2017-05-17 23:58:56]

The CQ bit was checked by paulirish@chromium.org

[paulirish, 2017-05-17 23:58:57]

lgtm

[paulirish, 2017-05-17 23:58:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2886073002/#ps40001
(title: "address feedback")

[commit-bot: I haz the power, 2017-05-18 00:00:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:39:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495065536735900,
"parent_rev": "0cfee008f8e847e088180928f6a024e5108038ea", "commit_rev":
"1846d7354ae835630ac31c6adf091e0e8cdaa54b"}

[commit-bot: I haz the power, 2017-05-18 03:39:49]

Description was changed from

==========
DevTools: prep audits panel for Lighthouse roll

* Adds lh-devtools class to report container
* Removes devtools filmstrip now that it has been upstreamed to Lighthouse
* Changes AuditService to return an object containing the error message instead
of null 

R=paulirish,pfeldman
==========

to

==========
DevTools: prep audits panel for Lighthouse roll

* Adds lh-devtools class to report container
* Removes devtools filmstrip now that it has been upstreamed to Lighthouse
* Changes AuditService to return an object containing the error message instead
of null 

R=paulirish,pfeldman

Review-Url: https://codereview.chromium.org/2886073002
Cr-Commit-Position: refs/heads/master@{#472640}
Committed:
https://chromium.googlesource.com/chromium/src/+/1846d7354ae835630ac31c6adf09...
==========

[commit-bot: I haz the power, 2017-05-18 03:39:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1846d7354ae835630ac31c6adf09...