DevTools: Roll Lighthouse binary to 2.0.1-alpha.0

DevTools: Roll Lighthouse binary to 2.0.1-alpha.0
Hash: 2d48f672e01c6e14cecd644608465c4015d8884d

BUG=663085
R=pfeldman@chromium.org, phulce@chromium.org

Review-Url: https://codereview.chromium.org/2888263002 .
Cr-Commit-Position: refs/heads/master@{#474075}
Committed: https://chromium.googlesource.com/chromium/src/+/edbae7b783028d90a0fb36b47222fc1b03ef201b

[paulirish, 2017-05-18 00:45:04]

paulirish@chromium.org changed reviewers:
+ pfeldman@chromium.org, phulce@chromium.org

[paulirish, 2017-05-18 00:45:05]

Also includes a lighthouse-background roll

PTAL

[paulirish, 2017-05-18 00:46:42]

Description was changed from

==========
DevTools: Roll Lighthouse binary to 2.0.0-alpha.7
Hash: aebc9bdf53754ffd360f7c54c752b046383c2d1b

BUG=
==========

to

==========
DevTools: Roll Lighthouse binary to 2.0.0-alpha.7
Hash: aebc9bdf53754ffd360f7c54c752b046383c2d1b

BUG=663085
==========

[phulce, 2017-05-18 00:48:07]

lgtm

https://codereview.chromium.org/2888263002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2888263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:284: var
body = '&body=' + encodeURI(issueBody);
wanna trim it too for newlines?

[pfeldman, 2017-05-18 00:51:38]

lgtm

[paulirish, 2017-05-18 01:03:38]

added the exception message to the bug report dialog.

https://codereview.chromium.org/2888263002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2888263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:284: var
body = '&body=' + encodeURI(issueBody);
On 2017/05/18 at 00:48:06, phulce wrote:
> wanna trim it too for newlines?

done

[phulce, 2017-05-18 04:33:01]

https://codereview.chromium.org/2888263002/diff/10001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2888263002/diff/10001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:285: var
body = '&body=' + encodeURI(issueBody.trim());
we should use `encodeURIComponent`, just ran into a case where the URL had a
query string and the `=` causes GitHub to truncate the message, but can do in a
followup if we need to :)

[paulirish, 2017-05-18 05:19:15]

Description was changed from

==========
DevTools: Roll Lighthouse binary to 2.0.0-alpha.7
Hash: aebc9bdf53754ffd360f7c54c752b046383c2d1b

BUG=663085
==========

to

==========
DevTools: Roll Lighthouse binary to 2.0.0-alpha.7
Hash: aebc9bdf53754ffd360f7c54c752b046383c2d1b

BUG=663085
R=pfeldman@chromium.org, phulce@chromium.org

Review-Url: https://codereview.chromium.org/2888263002 .
Cr-Commit-Position: refs/heads/master@{#472680}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b84a98141df91643a05bcb8e81c...
==========

[paulirish, 2017-05-18 05:19:18]

Committed patchset #3 (id:20001) manually as
5b84a98141df91643a05bcb8e81c9f0398e6ba81.

[Marc Treib, 2017-05-18 08:22:21]

A revert of this CL (patchset #3 id:20001) has been created in
https://codereview.chromium.org/2887313002/ by treib@chromium.org.

The reason for reverting is: Breaks devtools_closure_compile and
devtools_eslint:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/....

[Marc Treib, 2017-05-18 08:44:21]

On 2017/05/18 08:22:21, Marc Treib wrote:
> A revert of this CL (patchset #3 id:20001) has been created in
> https://codereview.chromium.org/2887313002/ by mailto:treib@chromium.org.
> 
> The reason for reverting is: Breaks devtools_closure_compile and
> devtools_eslint:
>
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/....

The actual landed change (crrev.com/5b84a98141df91643a05bcb8e81c9f0398e6ba81)
contains lots of changes to
WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js,
which do not show up in Rietveld. Any idea what's up with that?

[paulirish, 2017-05-18 20:19:33]

Description was changed from

==========
DevTools: Roll Lighthouse binary to 2.0.0-alpha.7
Hash: aebc9bdf53754ffd360f7c54c752b046383c2d1b

BUG=663085
R=pfeldman@chromium.org, phulce@chromium.org

Review-Url: https://codereview.chromium.org/2888263002 .
Cr-Commit-Position: refs/heads/master@{#472680}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b84a98141df91643a05bcb8e81c...
==========

to

==========
DevTools: Roll Lighthouse binary to 2.0.0-alpha.7
Hash: aebc9bdf53754ffd360f7c54c752b046383c2d1b

BUG=663085
R=pfeldman@chromium.org, phulce@chromium.org

Review-Url: https://codereview.chromium.org/2888263002 .
Cr-Original-Commit-Position: refs/heads/master@{#472680}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b84a98141df91643a05bcb8e81c...
Review-Url: https://codereview.chromium.org/2888263002 .
Cr-Commit-Position: refs/heads/master@{#472913}
Committed:
https://chromium.googlesource.com/chromium/src/+/a9b28ebe7c619f7025e9b9c20671...
==========

[paulirish, 2017-05-18 20:19:34]

Committed patchset #5 (id:40001) manually as
a9b28ebe7c619f7025e9b9c20671967eb3a440f3.

[paulirish, 2017-05-18 20:23:46]

On 2017/05/18 at 08:44:21, treib wrote:
> The actual landed change (crrev.com/5b84a98141df91643a05bcb8e81c9f0398e6ba81)
contains lots of changes to
WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js,
which do not show up in Rietveld. Any idea what's up with that?

Thanks for helping out, trieb.
lighthouse-background.js is > 600kb which is when reitveld starts breaking. :) 
So yeah it doesn't show up over here in codereview, but otherwise should be
fine.

Appreciate the revert.

[pasko, 2017-05-19 12:22:22]

A revert of this CL (patchset #5 id:40001) has been created in
https://codereview.chromium.org/2894113002/ by pasko@chromium.org.

The reason for reverting is: webview perfbot failing with:

TraceImportError: No clock sync markers exist pairing clock domain
"LINUX_FTRACE_GLOBAL" with target clock domain "TELEMETRY".

http://crbug.com/724423.

[paulirish, 2017-05-23 19:57:50]

The CQ bit was checked by paulirish@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 19:58:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[paulirish, 2017-05-23 19:59:22]

Description was changed from

==========
DevTools: Roll Lighthouse binary to 2.0.0-alpha.7
Hash: aebc9bdf53754ffd360f7c54c752b046383c2d1b

BUG=663085
R=pfeldman@chromium.org, phulce@chromium.org

Review-Url: https://codereview.chromium.org/2888263002 .
Cr-Original-Commit-Position: refs/heads/master@{#472680}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b84a98141df91643a05bcb8e81c...
Review-Url: https://codereview.chromium.org/2888263002 .
Cr-Commit-Position: refs/heads/master@{#472913}
Committed:
https://chromium.googlesource.com/chromium/src/+/a9b28ebe7c619f7025e9b9c20671...
==========

to

==========
DevTools: Roll Lighthouse binary to 2.0.1-alpha.0
Hash: 2d48f672e01c6e14cecd644608465c4015d8884d

BUG=663085
R=pfeldman@chromium.org, phulce@chromium.org
==========

[paulirish, 2017-05-23 20:00:40]

The CQ bit was checked by paulirish@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 20:01:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 21:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 21:52:12]

Dry run: This issue passed the CQ dry run.

[paulirish, 2017-05-23 21:57:12]

Description was changed from

==========
DevTools: Roll Lighthouse binary to 2.0.1-alpha.0
Hash: 2d48f672e01c6e14cecd644608465c4015d8884d

BUG=663085
R=pfeldman@chromium.org, phulce@chromium.org
==========

to

==========
DevTools: Roll Lighthouse binary to 2.0.1-alpha.0
Hash: 2d48f672e01c6e14cecd644608465c4015d8884d

BUG=663085
R=pfeldman@chromium.org, phulce@chromium.org

Review-Url: https://codereview.chromium.org/2888263002 .
Cr-Commit-Position: refs/heads/master@{#474075}
Committed:
https://chromium.googlesource.com/chromium/src/+/edbae7b783028d90a0fb36b47222...
==========

[paulirish, 2017-05-23 21:57:14]

Committed patchset #7 (id:60001) manually as
edbae7b783028d90a0fb36b47222fc1b03ef201b (presubmit successful).