third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js - Issue 2886073002: DevTools: prep audits panel for Lighthouse roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js

Issue 2886073002: DevTools: prep audits panel for Lighthouse roll (Closed)

Patch Set: address feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js

diff --git a/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js b/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js

index 65dd3543a1e2e79958948e434b7cc00277c8e4cd..1602c38a7cc4fa30ab4e5b28695cfccadf80016d 100644

--- a/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js

+++ b/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js

@@ -56,7 +56,11 @@ var Audits2Service = class {

result.artifacts = {traces: traces};

return result;

})

- .catchException(null);

+ .catch(err => ({

+ fatal: true,

+ message: err.message,

+ stack: err.stack,

+ }));

}

/**

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css ('k') | no next file » | no next file with comments »