Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2885403002: Fix DCHECK_IS_ON() iOS build (Closed)

Created:
3 years, 7 months ago by gab
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK_IS_ON() iOS build Extracted from https://codereview.chromium.org/2886803002/ BUG=722827 TBR=sdefresne Review-Url: https://codereview.chromium.org/2885403002 Cr-Commit-Position: refs/heads/master@{#472445} Committed: https://chromium.googlesource.com/chromium/src/+/ab611961b4bf7919c37a26491cc79376a4b07f7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ios/web/web_state/ui/wk_web_view_configuration_provider.mm View 1 chunk +4 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
gab
iOS fix extracted from https://codereview.chromium.org/2886803002/ TBR sdfresne
3 years, 7 months ago (2017-05-17 13:45:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885403002/1
3 years, 7 months ago (2017-05-17 13:46:17 UTC) #5
sdefresne
On 2017/05/17 13:46:17, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 7 months ago (2017-05-17 13:58:10 UTC) #6
sdefresne
lgtm
3 years, 7 months ago (2017-05-17 13:59:12 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 14:01:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab611961b4bf7919c37a26491cc7...

Powered by Google App Engine
This is Rietveld 408576698