Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2888783004:
NOINLINE in VideoCaptureOracle::IsFrameInRecentHistory to address issue 723090 (Closed)
|
Created:
3 years, 7 months ago by gab Modified:
3 years, 7 months ago Reviewers:
miu CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, xjz+watch_chromium.org, mfoltz+watch_chromium.org, miu+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionNOINLINE in VideoCaptureOracle::IsFrameInRecentHistory to address issue 723090
Inlining was the issue, tested @ https://codereview.chromium.org/2890783002/
with (PS3) and without (PS2) this change. Only compiles with.
BUG=723090
Review-Url: https://codereview.chromium.org/2888783004
Cr-Commit-Position: refs/heads/master@{#472663}
Committed: https://chromium.googlesource.com/chromium/src/+/2a81129250714241687f3a8f51fb0915aa4f1a6f
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 20 (16 generated)
gab@chromium.org changed reviewers: + miu@chromium.org
@miu PTaL, thanks!
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by miu@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495077085529970, "parent_rev":
"836c2795069269dfd38a0eb0fbed0027f5886955", "commit_rev":
"2a81129250714241687f3a8f51fb0915aa4f1a6f"}
Message was sent while issue was closed.
Description was changed from ========== NOINLINE in VideoCaptureOracle::IsFrameInRecentHistory to address issue 723090 Inlining was the issue, tested @ https://codereview.chromium.org/2890783002/ with (PS3) and without (PS2) this change. Only compiles with. BUG=723090 ========== to ========== NOINLINE in VideoCaptureOracle::IsFrameInRecentHistory to address issue 723090 Inlining was the issue, tested @ https://codereview.chromium.org/2890783002/ with (PS3) and without (PS2) this change. Only compiles with. BUG=723090 Review-Url: https://codereview.chromium.org/2888783004 Cr-Commit-Position: refs/heads/master@{#472663} Committed: https://chromium.googlesource.com/chromium/src/+/2a81129250714241687f3a8f51fb... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2a81129250714241687f3a8f51fb... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
