Chromium Code Reviews Chromium Code Reviews
Issue
2890783002:
Reland of Enable DCHECKs by default in non-official builds.
DescriptionReland of Enable DCHECKs by default in non-official builds. (patchset #1 id:1 of https://codereview.chromium.org/2892473002/ )
Reason for revert:
Generating reland CL, won't land until identified blockers have been fixed.
Original issue's description:
> Revert of Enable DCHECKs by default in non-official builds. (patchset #3 id:40001 of https://codereview.chromium.org/2886803002/ )
>
> Reason for revert:
>
> Findit (https://goo.gl/kROfz5) identified CL at revision 472195 as the
> culprit for failures in the build cycles as shown on:
> https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg3NWEyZmE0M2NhYWIwZWU4MmVmZTY4ZmI1YWRiMzU3MzkyNDM0YWQM
>
> Original issue's description:
> > Enable DCHECKs by default in non-official builds.
> >
> > BUG=722827
> > TBR=sdefresne@chromium.org for ios/
> >
> > Review-Url: https://codereview.chromium.org/2886803002
> > Cr-Commit-Position: refs/heads/master@{#472195}
> > Committed: https://chromium.googlesource.com/chromium/src/+/875a2fa43caab0ee82efe68fb5adb357392434ad
>
> TBR=brettw@chromium.org,thakis@chromium.org,sdefresne@chromium.org,gab@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=722827, 723090, 723049
>
> Review-Url: https://codereview.chromium.org/2892473002
> Cr-Commit-Position: refs/heads/master@{#472242}
> Committed: https://chromium.googlesource.com/chromium/src/+/8cc767cb0d1c65af6d5a36858c9633c929b7e4cd
TBR=kolos@google.com,peria@google.com,gab@google.com,dmazzoni@google.com,thakis@chromium.org,sdefresne@chromium.org,brettw@chromium.org,dmazzoni@chromium.org,findit-for-me@appspot.gserviceaccount.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=722827
Patch Set 1 #Patch Set 2 : rebase on https://codereview.chromium.org/2885403002/ #Patch Set 3 : NOINLINE in VideoCaptureOracle::IsFrameInRecentHistory to address issue 723090 #
Depends on Patchset: Messages
Total messages: 15 (5 generated)
|
||||||||||||||||||||||||||||
