Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 2885223002: Protobuf: Remove protobuf globals patch (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by Tom Anderson
Modified:
1 month, 1 week ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Protobuf: Remove protobuf globals patch The mir project has been cancelled [1], so Chromium will never need to support it. libmirclient has previously interfered with developer builds [2], leading to a complex hack [3] that placed all global variables in libprotobuf-lite into their own shared library. This CL adds a libmirclient.so.9 stub on Linux component builds. The library will get loaded, but its symbols will never be used by Chromium directly, or through GDK since only the X11 backend (and wayland in the future) is whitelisted [4]. [1] https://arstechnica.com/information-technology/2017/04/ubuntu-unity-is-dead-desktop-will-switch-back-to-gnome-next-year/ [2] https://crbug.com/700120 [3] https://codereview.chromium.org/2756543002/ [4] https://cs.chromium.org/chromium/src/chrome/browser/ui/libgtkui/gtk_ui.cc?rcl=50612fa00dfc8e79fe5bc92e2f235eee645739e9&l=434 R=pkasting@chromium.org BUG=700120 Review-Url: https://codereview.chromium.org/2885223002 Cr-Commit-Position: refs/heads/master@{#473382} Committed: https://chromium.googlesource.com/chromium/src/+/d631661d3479da5ede2117586de8dcf6af66fed6

Patch Set 1 #

Patch Set 2 : Update README.chromium #

Patch Set 3 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -1268 lines) Patch
M third_party/protobuf/BUILD.gn View 1 5 chunks +16 lines, -32 lines 0 comments Download
M third_party/protobuf/README.chromium View 1 2 4 chunks +15 lines, -27 lines 0 comments Download
A third_party/protobuf/mirclient.cc View 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/protobuf/mirclient.map View 1 chunk +25 lines, -0 lines 0 comments Download
D third_party/protobuf/patches/0012-extract-globals.patch View 1 chunk +0 lines, -943 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/arena.h View 3 chunks +6 lines, -10 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/arena.cc View 6 chunks +18 lines, -12 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/extension_set.h View 6 chunks +15 lines, -17 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/extension_set.cc View 5 chunks +54 lines, -32 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/generated_message_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/generated_message_util.cc View 1 chunk +6 lines, -4 lines 0 comments Download
D third_party/protobuf/src/google/protobuf/globals.cc View 1 chunk +0 lines, -122 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/io/coded_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/protobuf/src/google/protobuf/io/coded_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/protobuf/src/google/protobuf/stubs/atomicops_internals_x86_gcc.h View 7 chunks +7 lines, -9 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/stubs/atomicops_internals_x86_gcc.cc View 2 chunks +29 lines, -8 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/stubs/common.cc View 7 chunks +36 lines, -40 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/stubs/structurally_valid.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/stubs/strutil.cc View 3 chunks +3 lines, -3 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 24 (19 generated)
Tom Anderson
pkasting@ ptal Only 2 new files are necessary: mirclient.cc and mirclient.map The .cc file shouldn't ...
1 month, 1 week ago (2017-05-19 21:02:59 UTC) #15
Peter Kasting
The README doesn't talk about the new files and they're not in any patch. Those ...
1 month, 1 week ago (2017-05-19 21:23:28 UTC) #17
Tom Anderson
On 2017/05/19 21:23:28, Peter Kasting wrote: > The README doesn't talk about the new files ...
1 month, 1 week ago (2017-05-19 21:47:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885223002/40001
1 month, 1 week ago (2017-05-19 21:48:36 UTC) #21
commit-bot: I haz the power
1 month, 1 week ago (2017-05-19 23:23:23 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d631661d3479da5ede2117586de8...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 23e94e589