Refactor content/renderer/device_sensors to use device/generic_sensor instead of device/sensors

Refactor content/renderer/device_sensors to use device/generic_sensor instead of device/sensors

//device/generic_sensors already has all the sensors that can be used 
to implement the DeviceOrientation event:
https://w3c.github.io/deviceorientation/spec-source-orientation.html

Currently, //content/renderer/device_sensors uses sensors from 
//device/sensors as its backend, and this CL refactors 
//content/renderer/device_sensors to use sensors from
//device/generic_sensor as the backend and removes //device/sensors.

BUG=721427

[juncai, 2017-05-17 23:14:41]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 23:15:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-05-17 23:17:23]

Description was changed from

==========
Refactor //content/renderer/device_sensors to use //device/generic_sensor

BUG=721427
==========

to

==========
Refactor content/renderer/device_sensors to use device/generic_sensor instead of
device/sensors

BUG=721427
==========

[commit-bot: I haz the power, 2017-05-17 23:22:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 23:22:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[juncai, 2017-05-17 23:39:34]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 23:40:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-05-17 23:45:46]

Description was changed from

==========
Refactor content/renderer/device_sensors to use device/generic_sensor instead of
device/sensors

BUG=721427
==========

to

==========
Refactor content/renderer/device_sensors to use device/generic_sensor instead of
device/sensors

This CL refactors //content/renderer/device_sensors to use sensors from
//device/generic_sensor as the backend and removes //device/sensors.

BUG=721427
==========

[juncai, 2017-05-18 00:03:41]

Description was changed from

==========
Refactor content/renderer/device_sensors to use device/generic_sensor instead of
device/sensors

This CL refactors //content/renderer/device_sensors to use sensors from
//device/generic_sensor as the backend and removes //device/sensors.

BUG=721427
==========

to

==========
Refactor content/renderer/device_sensors to use device/generic_sensor instead of
device/sensors

//device/generic_sensors already has all the sensors that can be used to
implement the DeviceOrientation event:
https://w3c.github.io/deviceorientation/spec-source-orientation.html

Currently, //content/renderer/device_sensors uses sensors from 
//device/sensors as its backend, and this CL refactors 
//content/renderer/device_sensors to use sensors from
//device/generic_sensor as the backend and removes //device/sensors.

BUG=721427
==========

[juncai, 2017-05-18 00:03:57]

Description was changed from

==========
Refactor content/renderer/device_sensors to use device/generic_sensor instead of
device/sensors

//device/generic_sensors already has all the sensors that can be used to
implement the DeviceOrientation event:
https://w3c.github.io/deviceorientation/spec-source-orientation.html

Currently, //content/renderer/device_sensors uses sensors from 
//device/sensors as its backend, and this CL refactors 
//content/renderer/device_sensors to use sensors from
//device/generic_sensor as the backend and removes //device/sensors.

BUG=721427
==========

to

==========
Refactor content/renderer/device_sensors to use device/generic_sensor instead of
device/sensors

//device/generic_sensors already has all the sensors that can be used 
to implement the DeviceOrientation event:
https://w3c.github.io/deviceorientation/spec-source-orientation.html

Currently, //content/renderer/device_sensors uses sensors from 
//device/sensors as its backend, and this CL refactors 
//content/renderer/device_sensors to use sensors from
//device/generic_sensor as the backend and removes //device/sensors.

BUG=721427
==========

[commit-bot: I haz the power, 2017-05-18 00:11:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 00:11:38]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[juncai, 2017-05-18 00:20:51]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 00:22:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 02:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 02:41:26]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[juncai, 2017-05-18 03:19:52]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 03:21:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 05:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 05:34:01]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[juncai, 2017-05-18 23:10:33]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 23:11:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-05-19 02:41:49]

juncai@chromium.org changed reviewers:
+ reillyg@chromium.org

[juncai, 2017-05-19 02:41:50]

Please take a look.

[commit-bot: I haz the power, 2017-05-19 05:17:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 05:17:12]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-05-19 20:04:09]

Can you break this up into a smaller patch by refactoring DeviceMotionEvent and
DeviceOrientationEvent separately and deleting //device/sensors in a followup?

[Reilly Grant (use Gerrit), 2017-05-19 20:20:11]

https://codereview.chromium.org/2885203004/diff/80001/content/renderer/device...
File content/renderer/device_sensors/device_orientation_absolute_event_pump.cc
(right):

https://codereview.chromium.org/2885203004/diff/80001/content/renderer/device...
content/renderer/device_sensors/device_orientation_absolute_event_pump.cc:22:
GetSensor(device::mojom::SensorType::ABSOLUTE_ORIENTATION, sensors_[0].get());
Can you combine these two lines into a single call?

https://codereview.chromium.org/2885203004/diff/80001/content/renderer/device...
File content/renderer/device_sensors/device_orientation_event_pump.cc (right):

https://codereview.chromium.org/2885203004/diff/80001/content/renderer/device...
content/renderer/device_sensors/device_orientation_event_pump.cc:34:
GetSensor(device::mojom::SensorType::MAGNETOMETER, sensors_[3].get());
We don't want to activate all four of these sensors at once, just 0, 1, or 2 and
3 so we should wait to find out if the preferred sensor type is available before
activating the fallback.

https://codereview.chromium.org/2885203004/diff/80001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/modules/device_orientation/WebDeviceMotionData.h
(right):

https://codereview.chromium.org/2885203004/diff/80001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/device_orientation/WebDeviceMotionData.h:47:
memset(this, 0, sizeof(*this));
This structure is no longer used for a shared buffer. The constructor should use
conventional means to initialize the bool fields to false.

[juncai, 2017-05-20 00:54:47]

On 2017/05/19 20:04:09, Reilly Grant wrote:
> Can you break this up into a smaller patch by refactoring DeviceMotionEvent
and
> DeviceOrientationEvent separately and deleting //device/sensors in a followup?

Sure, started a smaller CL that refactors DeciveMotionEvent:
https://codereview.chromium.org/2896583005/

[juncai, 2017-05-20 00:55:02]

https://codereview.chromium.org/2885203004/diff/80001/content/renderer/device...
File content/renderer/device_sensors/device_orientation_absolute_event_pump.cc
(right):

https://codereview.chromium.org/2885203004/diff/80001/content/renderer/device...
content/renderer/device_sensors/device_orientation_absolute_event_pump.cc:22:
GetSensor(device::mojom::SensorType::ABSOLUTE_ORIENTATION, sensors_[0].get());
On 2017/05/19 20:20:10, Reilly Grant wrote:
> Can you combine these two lines into a single call?

Fixed it in a new CL:
https://codereview.chromium.org/2896583005/

Done.

https://codereview.chromium.org/2885203004/diff/80001/content/renderer/device...
File content/renderer/device_sensors/device_orientation_event_pump.cc (right):

https://codereview.chromium.org/2885203004/diff/80001/content/renderer/device...
content/renderer/device_sensors/device_orientation_event_pump.cc:34:
GetSensor(device::mojom::SensorType::MAGNETOMETER, sensors_[3].get());
On 2017/05/19 20:20:11, Reilly Grant wrote:
> We don't want to activate all four of these sensors at once, just 0, 1, or 2
and
> 3 so we should wait to find out if the preferred sensor type is available
before
> activating the fallback.

Will fix it in the device orientation refactoring CL.

https://codereview.chromium.org/2885203004/diff/80001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/modules/device_orientation/WebDeviceMotionData.h
(right):

https://codereview.chromium.org/2885203004/diff/80001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/device_orientation/WebDeviceMotionData.h:47:
memset(this, 0, sizeof(*this));
On 2017/05/19 20:20:11, Reilly Grant wrote:
> This structure is no longer used for a shared buffer. The constructor should
use
> conventional means to initialize the bool fields to false.

Fixed it in a new CL:
https://codereview.chromium.org/2896583005/

Done.