Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 2885193002: Move more mus tests to service_unittest.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 days, 18 hours ago by Elliot Glaysher
Modified:
2 days, 12 hours ago
Reviewers:
Dirk Pranke (slow), jam
CC:
chromium-reviews, rjkroege
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more mus tests to service_unittest. This moves mus_ime_unittests, ui_struct_traits_unittests, input_device_unittests, mus_public_unittests, mus_demo_unittests to service_unittest. BUG=722546

Patch Set 1 #

Patch Set 2 : Also minus: input_device, mus_public, mus_demo tests #

Patch Set 3 : If I'm reading this right, mus_demo isn't desktop linux. #

Patch Set 4 : Rebase to ToT #

Patch Set 5 : This was backwards; not chromeoes. #

Patch Set 6 : While it was built on windows, mus_dmeo was never run on windows. #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -177 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M services/BUILD.gn View 1 2 3 4 5 2 chunks +19 lines, -2 lines 0 comments Download
M services/ui/demo/BUILD.gn View 1 2 chunks +15 lines, -19 lines 0 comments Download
M services/ui/ime/BUILD.gn View 2 chunks +7 lines, -16 lines 0 comments Download
M services/ui/ime/ime_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ime/test_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/input_devices/BUILD.gn View 1 2 chunks +1 line, -2 lines 0 comments Download
M services/ui/public/cpp/tests/BUILD.gn View 1 1 chunk +3 lines, -2 lines 0 comments Download
M services/ui/public/interfaces/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M services/ui/ws/BUILD.gn View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 2 3 4 5 6 5 chunks +0 lines, -30 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 4 5 6 6 chunks +0 lines, -48 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 3 4 5 6 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 3 4 5 6 5 chunks +0 lines, -20 lines 0 comments Download
M tools/determinism/deterministic_build_whitelist.pyl View 1 2 3 4 5 6 3 chunks +0 lines, -5 lines 0 comments Download
Commit queue not available (can’t edit this change).

Depends on Patchset:

Messages

Total messages: 40 (34 generated)
Elliot Glaysher
Part 2. (Of many.)
5 days, 16 hours ago (2017-05-16 23:33:08 UTC) #10
Dirk Pranke (slow)
lgtm
5 days, 15 hours ago (2017-05-16 23:52:26 UTC) #15
jam
lgtm
5 days, 14 hours ago (2017-05-17 01:23:18 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885193002/60001
2 days, 20 hours ago (2017-05-19 19:22:32 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885193002/120001
2 days, 15 hours ago (2017-05-19 23:42:29 UTC) #38
commit-bot: I haz the power
2 days, 12 hours ago (2017-05-20 02:58:35 UTC) #40
Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06