Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2901623002: Move more tests suites to services_unittests. (Closed)

Created:
3 years, 7 months ago by Elliot Glaysher
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, jam, sky
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org, chrome-grc-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more tests suites to services_unittests. Moves the tests in mus_gpu_unittests and resource_coordinator_unittest into services_unittests and remove references to the old targets. BUG=722546 Review-Url: https://codereview.chromium.org/2901623002 Cr-Commit-Position: refs/heads/master@{#473983} Committed: https://chromium.googlesource.com/chromium/src/+/a5ac6b4b9fc2170c8edad07d6a7666674da7f9ab

Patch Set 1 #

Patch Set 2 : gpu tests need to go behind use_aura #

Patch Set 3 : try commenting out resource_coordinator tests to try to fix android_n5x_swarming #

Patch Set 4 : Oh, it was never run on android previously... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -88 lines) Patch
M services/BUILD.gn View 3 2 chunks +3 lines, -0 lines 0 comments Download
M services/resource_coordinator/BUILD.gn View 1 2 3 3 chunks +7 lines, -22 lines 0 comments Download
M services/ui/gpu/BUILD.gn View 1 2 chunks +31 lines, -25 lines 0 comments Download
D services/ui/gpu/mus_gpu_unittests_app_manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download
A + services/ui/gpu/test_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 2 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/determinism/deterministic_build_whitelist.pyl View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (20 generated)
Elliot Glaysher
3 years, 7 months ago (2017-05-22 22:56:21 UTC) #8
jam
lgtm
3 years, 7 months ago (2017-05-23 01:15:00 UTC) #15
Elliot Glaysher
dpranke -> sky: tools/ stamp
3 years, 7 months ago (2017-05-23 17:22:40 UTC) #19
sky
LGTM
3 years, 7 months ago (2017-05-23 18:08:45 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901623002/60001
3 years, 7 months ago (2017-05-23 18:09:49 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/a5ac6b4b9fc2170c8edad07d6a7666674da7f9ab
3 years, 7 months ago (2017-05-23 18:18:18 UTC) #25
Dirk Pranke
3 years, 7 months ago (2017-05-23 20:12:39 UTC) #27
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698