Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2881283003: Remove the mus_clipboard target and merge it into service_unittests. (Closed)

Created:
3 years, 7 months ago by Elliot Glaysher
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, jam
CC:
chromium-reviews, rjkroege, sadrul, tfarina, dcheng, piman+watch_chromium.org, kalyank
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the mus_clipboard target and merge it into service_unittests. This is the first target moved from the legacy mus tests into service_unittests. BUG=722546 Review-Url: https://codereview.chromium.org/2881283003 Cr-Commit-Position: refs/heads/master@{#473022} Committed: https://chromium.googlesource.com/chromium/src/+/f4938cd4dbf88834816a592abeec512d240883d5

Patch Set 1 #

Patch Set 2 : Merge with tot? This gn failure is weird. #

Patch Set 3 : This is still broken on cast_shell_android. #

Patch Set 4 : use_aura in //services/BUILD.gn #

Messages

Total messages: 36 (24 generated)
Elliot Glaysher
3 years, 7 months ago (2017-05-16 19:51:42 UTC) #16
Dirk Pranke
lgtm
3 years, 7 months ago (2017-05-16 22:31:57 UTC) #17
Elliot Glaysher
ping jam
3 years, 7 months ago (2017-05-16 23:32:38 UTC) #18
jam
lgtm
3 years, 7 months ago (2017-05-17 01:22:14 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881283003/60001
3 years, 7 months ago (2017-05-17 17:09:51 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/217520)
3 years, 7 months ago (2017-05-17 19:10:55 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881283003/60001
3 years, 7 months ago (2017-05-17 19:18:04 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/429591)
3 years, 7 months ago (2017-05-18 02:36:17 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881283003/60001
3 years, 7 months ago (2017-05-18 17:09:31 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/429696)
3 years, 7 months ago (2017-05-18 19:15:03 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881283003/60001
3 years, 7 months ago (2017-05-18 19:31:27 UTC) #33
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 01:42:30 UTC) #36
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f4938cd4dbf88834816a592abeec...

Powered by Google App Engine
This is Rietveld 408576698