Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2885043004: ABANDONED CL: Make WebContents::Get(Original)Opener return RenderFrameHost* (not WebContents*). (Closed)

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, msramek+watch_chromium.org, creis+watch_chromium.org, speed-metrics-reviews_chromium.org, nasko+codewatch_chromium.org, jam, loading-reviews+metrics_chromium.org, csharrison+watch_chromium.org, darin-cc_chromium.org, raymes+watch_chromium.org, markusheintz_
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ABANDONED CL - merged into https://codereview.chromium.org/2882513005. ======================= Make WebContents::Get(Original)Opener return RenderFrameHost* (not WebContents*). This CL makes WebContents::GetOpener and WebContents::GetOriginalOpener methods more accurate, by having them return a specific frame (i.e. RenderFrameHost*) rather than a tab (i.e. WebContents*). Having an accurate opener is required to properly record UMA that tracks when the opener is a hosted app (i.e. this CL unblocks https://crrev.com/2877333004). OTOH, an accurate opener is desirable in general for the long term (unlike the UMA) and so we are landing the Get(Original)Opener change separately from the other CL. BUG=718516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M chrome/browser/content_settings/mixed_content_settings_tab_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/metrics_web_contents_observer.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/public/browser/web_contents.h View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2882513005 Patch 60001

Dependent Patchsets:

Messages

Total messages: 9 (9 generated)
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-16 21:57:56 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885043004/1
3 years, 7 months ago (2017-05-16 21:59:30 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-16 23:47:56 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/295531) linux_chromium_asan_rel_ng on ...
3 years, 7 months ago (2017-05-16 23:47:57 UTC) #4
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-17 00:13:42 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2885043004/1
3 years, 7 months ago (2017-05-17 00:15:34 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 01:35:58 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/427973) linux_chromium_rel_ng on ...
3 years, 7 months ago (2017-05-17 01:35:59 UTC) #8
Łukasz Anforowicz
3 years, 6 months ago (2017-05-27 00:03:20 UTC) #9 
Description was changed from

==========
Make WebContents::Get(Original)Opener return RenderFrameHost* (not
WebContents*).

This CL makes WebContents::GetOpener and WebContents::GetOriginalOpener
methods more accurate, by having them return a specific frame (i.e.
RenderFrameHost*) rather than a tab (i.e. WebContents*).

Having an accurate opener is required to properly record UMA that tracks
when the opener is a hosted app (i.e. this CL unblocks
https://crrev.com/2877333004).  OTOH, an accurate opener is desirable in
general for the long term (unlike the UMA) and so we are landing the
Get(Original)Opener change separately from the other CL.

BUG=718516
==========

to

==========
ABANDONED CL - merged into https://codereview.chromium.org/2882513005.

=======================

Make WebContents::Get(Original)Opener return RenderFrameHost* (not
WebContents*).

This CL makes WebContents::GetOpener and WebContents::GetOriginalOpener
methods more accurate, by having them return a specific frame (i.e.
RenderFrameHost*) rather than a tab (i.e. WebContents*).

Having an accurate opener is required to properly record UMA that tracks
when the opener is a hosted app (i.e. this CL unblocks
https://crrev.com/2877333004).  OTOH, an accurate opener is desirable in
general for the long term (unlike the UMA) and so we are landing the
Get(Original)Opener change separately from the other CL.

BUG=718516
==========

Powered by Google App Engine
This is Rietveld 408576698