content/browser/web_contents/web_contents_impl.h - Issue 2885043004: ABANDONED CL: Make WebContents::Get(Original)Opener return RenderFrameHost* (not WebContents*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2885043004: ABANDONED CL: Make WebContents::Get(Original)Opener return RenderFrameHost* (not WebContents*). (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index b17d669a1356fd98fbeb58f28f0daca32b1665ec..0640ed3daf3ca2624764a444b8ca76b46f324536 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -418,9 +418,9 @@ class CONTENT_EXPORT WebContentsImpl

gfx::Size GetPreferredSize() const override;

bool GotResponseToLockMouseRequest(bool allowed) override;

bool HasOpener() const override;

- WebContentsImpl* GetOpener() const override;

+ RenderFrameHostImpl* GetOpener() const override;

bool HasOriginalOpener() const override;

- WebContents* GetOriginalOpener() const override;

+ RenderFrameHostImpl* GetOriginalOpener() const override;

void DidChooseColorInColorChooser(SkColor color) override;

void DidEndColorChooser() override;

int DownloadImage(const GURL& url,