Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2885043004: ABANDONED CL: Make WebContents::Get(Original)Opener return RenderFrameHost* (not WebContents*). (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/public/browser/web_contents.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <utility> 10 #include <utility>
(...skipping 3324 matching lines...) Expand 10 before | Expand all | Expand 10 after
3335 current->mouse_lock_widget_ = nullptr; 3335 current->mouse_lock_widget_ = nullptr;
3336 } 3336 }
3337 3337
3338 return false; 3338 return false;
3339 } 3339 }
3340 3340
3341 bool WebContentsImpl::HasOpener() const { 3341 bool WebContentsImpl::HasOpener() const {
3342 return GetOpener() != NULL; 3342 return GetOpener() != NULL;
3343 } 3343 }
3344 3344
3345 WebContentsImpl* WebContentsImpl::GetOpener() const { 3345 RenderFrameHostImpl* WebContentsImpl::GetOpener() const {
3346 FrameTreeNode* opener_ftn = frame_tree_.root()->opener(); 3346 FrameTreeNode* opener_ftn = frame_tree_.root()->opener();
3347 return opener_ftn ? FromFrameTreeNode(opener_ftn) : nullptr; 3347 return opener_ftn ? opener_ftn->current_frame_host() : nullptr;
3348 } 3348 }
3349 3349
3350 bool WebContentsImpl::HasOriginalOpener() const { 3350 bool WebContentsImpl::HasOriginalOpener() const {
3351 return GetOriginalOpener() != NULL; 3351 return GetOriginalOpener() != NULL;
3352 } 3352 }
3353 3353
3354 WebContents* WebContentsImpl::GetOriginalOpener() const { 3354 RenderFrameHostImpl* WebContentsImpl::GetOriginalOpener() const {
3355 FrameTreeNode* opener_ftn = frame_tree_.root()->original_opener(); 3355 FrameTreeNode* opener_ftn = frame_tree_.root()->original_opener();
3356 return opener_ftn ? FromFrameTreeNode(opener_ftn) : nullptr; 3356 return opener_ftn ? opener_ftn->current_frame_host() : nullptr;
3357 } 3357 }
3358 3358
3359 void WebContentsImpl::DidChooseColorInColorChooser(SkColor color) { 3359 void WebContentsImpl::DidChooseColorInColorChooser(SkColor color) {
3360 if (!color_chooser_info_.get()) 3360 if (!color_chooser_info_.get())
3361 return; 3361 return;
3362 RenderFrameHost* rfh = RenderFrameHost::FromID( 3362 RenderFrameHost* rfh = RenderFrameHost::FromID(
3363 color_chooser_info_->render_process_id, 3363 color_chooser_info_->render_process_id,
3364 color_chooser_info_->render_frame_id); 3364 color_chooser_info_->render_frame_id);
3365 if (!rfh) 3365 if (!rfh)
3366 return; 3366 return;
(...skipping 2247 matching lines...) Expand 10 before | Expand all | Expand 10 after
5614 new_root->SetOriginalOpener(opener->frame_tree()->root()); 5614 new_root->SetOriginalOpener(opener->frame_tree()->root());
5615 5615
5616 if (!opener_suppressed) { 5616 if (!opener_suppressed) {
5617 new_root->SetOpener(opener); 5617 new_root->SetOpener(opener);
5618 created_with_opener_ = true; 5618 created_with_opener_ = true;
5619 } 5619 }
5620 } 5620 }
5621 } 5621 }
5622 5622
5623 } // namespace content 5623 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/public/browser/web_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698