Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2877333004: UMA for measuring how often 2 or more tabs script the same background contents.

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

UMA for measuring how often 2 or more tabs script the same background contents. BUG=721947 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : UMA from //chrome layer, but with an icky PostDelayedTask #

Patch Set 3 : UMA from Blink layer, but with a small layering violation. #

Patch Set 4 : No PostDelayedTask and checking if opener is a hosted app #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -4 lines) Patch
M chrome/browser/background/background_contents.h View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/background/background_contents.cc View 1 2 3 6 chunks +78 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_observer.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (13 generated)
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-15 19:38:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877333004/1
3 years, 7 months ago (2017-05-15 19:39:56 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-15 20:53:12 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/454828)
3 years, 7 months ago (2017-05-15 20:53:13 UTC) #4
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-15 23:50:49 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877333004/20001
3 years, 7 months ago (2017-05-15 23:51:51 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-16 02:18:49 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-05-16 02:18:49 UTC) #8
Łukasz Anforowicz
Description was changed from ========== UMA for measuring how often 2 or more tabs script ...
3 years, 7 months ago (2017-05-16 23:38:54 UTC) #9
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-16 23:39:02 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877333004/60001
3 years, 7 months ago (2017-05-16 23:40:38 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 00:39:50 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 00:39:50 UTC) #13
Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

Powered by Google App Engine
This is Rietveld 408576698