Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2884993002: Don't trigger full active style update on styleSheets access. (Closed)

Created:
3 years, 7 months ago by rune
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, tfarina, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't trigger full active style update on styleSheets access. Element.styleSheets and ShadowRoot.styleSheets need to be made up-to- date on access. We used to do a full active style update, but re- collecting the stylesheet list should be enough, leaving the active style dirty flags intact. We introduce a dirty-flag for the stylesheet list in StyleSheetCollection to avoid repeatedly re-collecting this list while the active style is still dirty. This coincidentally fixes issue 722826 since we do not collect stylesheets in import shadow trees as part of the active style update, but is now made up-to-date on request when accessing the styleSheets collection on shadow roots inside import documents. This fixes the performance issue 717506. R=meade@chromium.org BUG=717506, 722826 Review-Url: https://codereview.chromium.org/2884993002 Cr-Commit-Position: refs/heads/master@{#473846} Committed: https://chromium.googlesource.com/chromium/src/+/e1719ffa41c44d3434095850fee7ffa5b6e57c4f

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Not clearing document_scope_dirty_ flag in import styleSheets anymore. #

Messages

Total messages: 15 (11 generated)
rune
ptal
3 years, 7 months ago (2017-05-18 11:31:33 UTC) #7
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-23 04:38:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884993002/40001
3 years, 7 months ago (2017-05-23 08:10:46 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 10:08:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e1719ffa41c44d3434095850fee7...

Powered by Google App Engine
This is Rietveld 408576698