third_party/WebKit/Source/web/tests/HTMLImportSheetsTest.cpp - Issue 2884993002: Don't trigger full active style update on styleSheets access.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/web/tests/HTMLImportSheetsTest.cpp

Issue 2884993002: Don't trigger full active style update on styleSheets access. (Closed)

Patch Set: Not clearing document_scope_dirty_ flag in import styleSheets anymore. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/dom/Document.h"	5 #include "core/dom/Document.h"

6 #include "core/html/HTMLLinkElement.h"	6 #include "core/html/HTMLLinkElement.h"

7 #include "testing/gtest/include/gtest/gtest.h"	7 #include "testing/gtest/include/gtest/gtest.h"

8 #include "web/tests/sim/SimRequest.h"	8 #include "web/tests/sim/SimRequest.h"

9 #include "web/tests/sim/SimTest.h"	9 #include "web/tests/sim/SimTest.h"

10	10

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45	45

46 EXPECT_TRUE(GetDocument().GetStyleEngine().NeedsActiveStyleUpdate());	46 EXPECT_TRUE(GetDocument().GetStyleEngine().NeedsActiveStyleUpdate());

47 Document* import_doc =	47 Document* import_doc =

48 toHTMLLinkElement(GetDocument().getElementById("link"))->import();	48 toHTMLLinkElement(GetDocument().getElementById("link"))->import();

49 ASSERT_TRUE(import_doc);	49 ASSERT_TRUE(import_doc);

50 EXPECT_TRUE(import_doc->GetStyleEngine().NeedsActiveStyleUpdate());	50 EXPECT_TRUE(import_doc->GetStyleEngine().NeedsActiveStyleUpdate());

51	51

52 import_doc->GetStyleEngine().StyleSheetsForStyleSheetList(*import_doc);	52 import_doc->GetStyleEngine().StyleSheetsForStyleSheetList(*import_doc);

53	53

54 EXPECT_TRUE(GetDocument().GetStyleEngine().NeedsActiveStyleUpdate());	54 EXPECT_TRUE(GetDocument().GetStyleEngine().NeedsActiveStyleUpdate());

55 EXPECT_FALSE(import_doc->GetStyleEngine().NeedsActiveStyleUpdate());	55 EXPECT_TRUE(import_doc->GetStyleEngine().NeedsActiveStyleUpdate());

56 }	56 }

57	57

58 } // namespace blink	58 } // namespace blink

OLD	NEW