third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp - Issue 2884993002: Don't trigger full active style update on styleSheets access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp

Issue 2884993002: Don't trigger full active style update on styleSheets access. (Closed)

Patch Set: Not clearing document_scope_dirty_ flag in import styleSheets anymore. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.h ('k') | third_party/WebKit/Source/web/tests/HTMLImportSheetsTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp

diff --git a/third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp b/third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp

index a562dad86fa54b77d28064b2e85b79ec0e9ab35d..0f22c8735cc85dff050518fa468277de56dbdf7e 100644

--- a/third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp

+++ b/third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp

@@ -79,7 +79,10 @@ bool TreeScopeStyleSheetCollection::HasStyleSheets() const {

return false;

}

-void TreeScopeStyleSheetCollection::CollectStyleSheetsForList() {

+void TreeScopeStyleSheetCollection::UpdateStyleSheetList() {

+ if (!sheet_list_dirty_)

+ return;

HeapVector<Member<StyleSheet>> new_list;

for (Node* node : style_sheet_candidate_nodes_) {

StyleSheetCandidate candidate(*node);