[WebView] Remove more redundant classes

[WebView] Remove more redundant classes

Since we removed native/ layer, we could make jni calls
from browser/, so no need of separation anymore.

This CL:

1) Merged
aw_http_auth_handler_base.{h,cc} -> aw_http_auth_handler.{h,cc}

2) Removed
aw_locale_manager.h
aw_locale_manager_impl.{h,cc}
aw_web_preferences_populater.{h,cc}
aw_web_preferences_populater_impl.{h,cc}

3) Removed corresponding class factory functions in
JniDependencyFactory and AwMainDelegate.

BUG=716604
Review-Url: https://codereview.chromium.org/2884353003
Cr-Commit-Position: refs/heads/master@{#472580}
Committed: https://chromium.googlesource.com/chromium/src/+/45f8d9f431184fa691b3671c22618e540bb0b286

[Shimi Zhang, 2017-05-17 01:02:59]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 01:05:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shimi Zhang, 2017-05-17 01:17:27]

Description was changed from

==========
[WebView] Remove some redundant classes

Since we removed native/ layer, we could make jni calls
from browser/, so no need of separation anymore.

This CL removes:

aw_http_auth_handler_base.{h,cc}
aw_locale_manager_impl.{h,cc}
aw_web_preferences_populater_impl.{h,cc}

Also removed corresponding class factory functions in
JniDependencyFactory and AwMainDelegate

BUG=716604
==========

to

==========
[WebView] Merge more redundant classes

Since we removed native/ layer, we could make jni calls
from browser/, so no need of separation anymore.

This CL:

1) Merged
aw_http_auth_handler_base.{h,cc} -> aw_http_auth_handler.{h,cc}
aw_locale_manager_impl.{h,cc} -> aw_locale_manager.{h,cc}
aw_web_preferences_populater_impl.{h,cc} -> aw_web_preferences_populater.{h,cc}

2) Removed corresponding class factory functions in
JniDependencyFactory and AwMainDelegate.

BUG=716604
==========

[Shimi Zhang, 2017-05-17 01:19:39]

ctzsm@chromium.org changed reviewers:
+ boliu@chromium.org

[Shimi Zhang, 2017-05-17 01:19:39]

Bo, PTAL, thanks!

This is another CL merges native/ and browser/ classes.

[commit-bot: I haz the power, 2017-05-17 07:22:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 07:22:48]

Dry run: This issue passed the CQ dry run.

[boliu, 2017-05-17 16:18:11]

https://codereview.chromium.org/2884353003/diff/1/android_webview/browser/aw_...
File android_webview/browser/aw_locale_manager.cc (right):

https://codereview.chromium.org/2884353003/diff/1/android_webview/browser/aw_...
android_webview/browser/aw_locale_manager.cc:11: std::string
AwLocaleManager::GetLocale() {
this one too, remove this class and just inline the calls

https://codereview.chromium.org/2884353003/diff/1/android_webview/browser/aw_...
File android_webview/browser/aw_web_preferences_populater.cc (right):

https://codereview.chromium.org/2884353003/diff/1/android_webview/browser/aw_...
android_webview/browser/aw_web_preferences_populater.cc:10: void
AwWebPreferencesPopulater::PopulateFor(
you can remove this class entirely and just inline body of this method in
aw_content_browser_client.cc

[Shimi Zhang, 2017-05-17 18:02:44]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[Shimi Zhang, 2017-05-17 18:04:52]

Description was changed from

==========
[WebView] Merge more redundant classes

Since we removed native/ layer, we could make jni calls
from browser/, so no need of separation anymore.

This CL:

1) Merged
aw_http_auth_handler_base.{h,cc} -> aw_http_auth_handler.{h,cc}
aw_locale_manager_impl.{h,cc} -> aw_locale_manager.{h,cc}
aw_web_preferences_populater_impl.{h,cc} -> aw_web_preferences_populater.{h,cc}

2) Removed corresponding class factory functions in
JniDependencyFactory and AwMainDelegate.

BUG=716604
==========

to

==========
[WebView] Merge more redundant classes

Since we removed native/ layer, we could make jni calls
from browser/, so no need of separation anymore.

This CL:

1) Merged
aw_http_auth_handler_base.{h,cc} -> aw_http_auth_handler.{h,cc}

2) Removed
aw_locale_manager.h
aw_locale_manager_impl.{h,cc}
aw_web_preferences_populater.{h,cc}
aw_web_preferences_populater_impl.{h,cc}

3) Removed corresponding class factory functions in
JniDependencyFactory and AwMainDelegate.

BUG=716604
==========

[commit-bot: I haz the power, 2017-05-17 18:04:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shimi Zhang, 2017-05-17 18:06:34]

On 2017/05/17 16:18:11, boliu wrote:
>
https://codereview.chromium.org/2884353003/diff/1/android_webview/browser/aw_...
> File android_webview/browser/aw_locale_manager.cc (right):
> 
>
https://codereview.chromium.org/2884353003/diff/1/android_webview/browser/aw_...
> android_webview/browser/aw_locale_manager.cc:11: std::string
> AwLocaleManager::GetLocale() {
> this one too, remove this class and just inline the calls
> 
>
https://codereview.chromium.org/2884353003/diff/1/android_webview/browser/aw_...
> File android_webview/browser/aw_web_preferences_populater.cc (right):
> 
>
https://codereview.chromium.org/2884353003/diff/1/android_webview/browser/aw_...
> android_webview/browser/aw_web_preferences_populater.cc:10: void
> AwWebPreferencesPopulater::PopulateFor(
> you can remove this class entirely and just inline body of this method in
> aw_content_browser_client.cc

neat!

Updated, PTAL.

[commit-bot: I haz the power, 2017-05-17 18:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 18:13:06]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Shimi Zhang, 2017-05-17 18:15:11]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 18:16:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shimi Zhang, 2017-05-17 18:44:36]

Description was changed from

==========
[WebView] Merge more redundant classes

Since we removed native/ layer, we could make jni calls
from browser/, so no need of separation anymore.

This CL:

1) Merged
aw_http_auth_handler_base.{h,cc} -> aw_http_auth_handler.{h,cc}

2) Removed
aw_locale_manager.h
aw_locale_manager_impl.{h,cc}
aw_web_preferences_populater.{h,cc}
aw_web_preferences_populater_impl.{h,cc}

3) Removed corresponding class factory functions in
JniDependencyFactory and AwMainDelegate.

BUG=716604
==========

to

==========
[WebView] Remove more redundant classes

Since we removed native/ layer, we could make jni calls
from browser/, so no need of separation anymore.

This CL:

1) Merged
aw_http_auth_handler_base.{h,cc} -> aw_http_auth_handler.{h,cc}

2) Removed
aw_locale_manager.h
aw_locale_manager_impl.{h,cc}
aw_web_preferences_populater.{h,cc}
aw_web_preferences_populater_impl.{h,cc}

3) Removed corresponding class factory functions in
JniDependencyFactory and AwMainDelegate.

BUG=716604
==========

[Shimi Zhang, 2017-05-17 18:51:46]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 18:52:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-05-17 18:54:54]

lgtm

[commit-bot: I haz the power, 2017-05-17 20:37:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:37:34]

Dry run: This issue passed the CQ dry run.

[Shimi Zhang, 2017-05-17 21:27:38]

The CQ bit was checked by ctzsm@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:28:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 21:52:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495056458323980,
"parent_rev": "447617afdade1a98437ffab3bde18c7100fcd667", "commit_rev":
"45f8d9f431184fa691b3671c22618e540bb0b286"}

[commit-bot: I haz the power, 2017-05-17 21:53:02]

Description was changed from

==========
[WebView] Remove more redundant classes

Since we removed native/ layer, we could make jni calls
from browser/, so no need of separation anymore.

This CL:

1) Merged
aw_http_auth_handler_base.{h,cc} -> aw_http_auth_handler.{h,cc}

2) Removed
aw_locale_manager.h
aw_locale_manager_impl.{h,cc}
aw_web_preferences_populater.{h,cc}
aw_web_preferences_populater_impl.{h,cc}

3) Removed corresponding class factory functions in
JniDependencyFactory and AwMainDelegate.

BUG=716604
==========

to

==========
[WebView] Remove more redundant classes

Since we removed native/ layer, we could make jni calls
from browser/, so no need of separation anymore.

This CL:

1) Merged
aw_http_auth_handler_base.{h,cc} -> aw_http_auth_handler.{h,cc}

2) Removed
aw_locale_manager.h
aw_locale_manager_impl.{h,cc}
aw_web_preferences_populater.{h,cc}
aw_web_preferences_populater_impl.{h,cc}

3) Removed corresponding class factory functions in
JniDependencyFactory and AwMainDelegate.

BUG=716604

Review-Url: https://codereview.chromium.org/2884353003
Cr-Commit-Position: refs/heads/master@{#472580}
Committed:
https://chromium.googlesource.com/chromium/src/+/45f8d9f431184fa691b3671c2261...
==========

[commit-bot: I haz the power, 2017-05-17 21:53:04]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/45f8d9f431184fa691b3671c2261...