android_webview/browser/aw_web_preferences_populater.cc - Issue 2884353003: [WebView] Remove more redundant classes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/browser/aw_web_preferences_populater.cc

Issue 2884353003: [WebView] Remove more redundant classes (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "android_webview/browser/aw_web_preferences_populater.h"	5 #include "android_webview/browser/aw_web_preferences_populater.h"

	6 #include "android_webview/browser/aw_settings.h"

6	7

7 namespace android_webview {	8 namespace android_webview {

8	9

9 AwWebPreferencesPopulater::~AwWebPreferencesPopulater() {}	10 void AwWebPreferencesPopulater::PopulateFor(
	boliu 2017/05/17 16:18:11 you can remove this class entirely and just inline you can remove this class entirely and just inline body of this method in aw_content_browser_client.cc
	11 content::WebContents* web_contents,

	12 content::WebPreferences* web_prefs) {

	13 AwSettings* aw_settings = AwSettings::FromWebContents(web_contents);

	14 if (aw_settings) {

	15 aw_settings->PopulateWebPreferences(web_prefs);

	16 }

	17 }

10	18

11 } // namespace android_webview	19 } // namespace android_webview

OLD	NEW