Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2618)

Unified Diff: android_webview/browser/aw_http_auth_handler.h

Issue 2884353003: [WebView] Remove more redundant classes (Closed)
Patch Set: add missing header Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_http_auth_handler.h
diff --git a/android_webview/browser/aw_http_auth_handler.h b/android_webview/browser/aw_http_auth_handler.h
index 5fdc9881a4cb3bf04d25ad6d231d224084a9fd1e..e05a080a8c46554d4bee904effbc6b68654b3f51 100644
--- a/android_webview/browser/aw_http_auth_handler.h
+++ b/android_webview/browser/aw_http_auth_handler.h
@@ -8,8 +8,6 @@
#include <jni.h>
#include <string>
-#include "android_webview/browser/aw_http_auth_handler_base.h"
-#include "android_webview/browser/aw_login_delegate.h"
#include "base/android/jni_android.h"
#include "base/android/scoped_java_ref.h"
#include "base/memory/ref_counted.h"
@@ -24,18 +22,23 @@ class AuthChallengeInfo;
namespace android_webview {
+class AwLoginDelegate;
+
// Native class for Java class of same name and owns an instance
// of that Java object.
// One instance of this class is created per underlying AwLoginDelegate.
-class AwHttpAuthHandler : public AwHttpAuthHandlerBase {
+class AwHttpAuthHandler {
public:
+ static AwHttpAuthHandler* Create(AwLoginDelegate* login_delegate,
+ net::AuthChallengeInfo* auth_info,
+ bool first_auth_attempt);
AwHttpAuthHandler(AwLoginDelegate* login_delegate,
net::AuthChallengeInfo* auth_info,
bool first_auth_attempt);
- ~AwHttpAuthHandler() override;
+ ~AwHttpAuthHandler();
// from AwHttpAuthHandler
- bool HandleOnUIThread(content::WebContents* web_contents) override;
+ bool HandleOnUIThread(content::WebContents* web_contents);
void Proceed(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
« no previous file with comments | « android_webview/browser/aw_content_browser_client.cc ('k') | android_webview/browser/aw_http_auth_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698