Remove unused embeddedSearch.searchBox APIs

Remove unused embeddedSearch.searchBox APIs

This removes the following two unused APIs from searchbox_api.js:
this.__defineGetter__('rtl', GetRightToLeft);
this.__defineGetter__('value', GetQuery);

along with all the supporting code.

BUG=552720
Review-Url: https://codereview.chromium.org/2884293002
Cr-Commit-Position: refs/heads/master@{#473276}
Committed: https://chromium.googlesource.com/chromium/src/+/a780f4e12a9ac930d8e051d502ba1b40e862ec17

[Marc Treib, 2017-05-16 15:57:11]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 15:57:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 16:34:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 16:34:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Marc Treib, 2017-05-16 16:38:06]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 16:39:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 18:39:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 18:39:10]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-05-17 08:01:41]

Description was changed from

==========
Remove unused embeddedSearch.searchBox APIs

BUG=552720
==========

to

==========
Remove unused embeddedSearch.searchBox APIs

This removes the following two unused APIs from searchbox_api.js:
this.__defineGetter__('rtl', GetRightToLeft);
this.__defineGetter__('value', GetQuery);

along with all the supporting code.

BUG=552720
==========

[Marc Treib, 2017-05-17 08:02:02]

treib@chromium.org changed reviewers:
+ pkasting@chromium.org

[Marc Treib, 2017-05-17 08:02:03]

PTAL!

https://codereview.chromium.org/2884293002/diff/20001/chrome/renderer/searchb...
File chrome/renderer/searchbox/searchbox.cc (left):

https://codereview.chromium.org/2884293002/diff/20001/chrome/renderer/searchb...
chrome/renderer/searchbox/searchbox.cc:422: if (!query.empty())
Removing this check looks like a logical change, but in practice, both
BrowserInstantController and InstantSearchPrerenderer make sure the query is
non-empty before starting the chain of Commit/Submit calls.

[Peter Kasting, 2017-05-17 23:06:35]

LGTM

[Marc Treib, 2017-05-18 07:55:35]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2017-05-18 07:55:37]

The CQ bit was unchecked by treib@chromium.org

[Marc Treib, 2017-05-18 07:57:19]

treib@chromium.org changed reviewers:
+ palmer@chromium.org

[Marc Treib, 2017-05-18 07:57:19]

+palmer for change to chrome/common/instant.mojom, PTAL!

[Marc Treib, 2017-05-19 13:17:36]

On 2017/05/18 07:57:19, Marc Treib wrote:
> +palmer for change to chrome/common/instant.mojom, PTAL!

Ping!

FYI: I'll be out the next two weeks. If this looks good to you, please feel free
to check the "Commit" box. Thanks!

[palmer, 2017-05-19 18:29:27]

lgtm

[palmer, 2017-05-19 18:29:58]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2017-05-19 18:31:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 19:35:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495218598450870,
"parent_rev": "ecba95904f5568af622a7baea4a4dab9b92a9e75", "commit_rev":
"a780f4e12a9ac930d8e051d502ba1b40e862ec17"}

[commit-bot: I haz the power, 2017-05-19 19:35:34]

Description was changed from

==========
Remove unused embeddedSearch.searchBox APIs

This removes the following two unused APIs from searchbox_api.js:
this.__defineGetter__('rtl', GetRightToLeft);
this.__defineGetter__('value', GetQuery);

along with all the supporting code.

BUG=552720
==========

to

==========
Remove unused embeddedSearch.searchBox APIs

This removes the following two unused APIs from searchbox_api.js:
this.__defineGetter__('rtl', GetRightToLeft);
this.__defineGetter__('value', GetQuery);

along with all the supporting code.

BUG=552720

Review-Url: https://codereview.chromium.org/2884293002
Cr-Commit-Position: refs/heads/master@{#473276}
Committed:
https://chromium.googlesource.com/chromium/src/+/a780f4e12a9ac930d8e051d502ba...
==========

[commit-bot: I haz the power, 2017-05-19 19:35:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a780f4e12a9ac930d8e051d502ba...