Remove unused embeddedSearch.searchBox APIs

chrome/renderer/searchbox/searchbox.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/searchbox/searchbox.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <string>
@@ skipping 211 matching lines @@
 }
 
 SearchBox::SearchBox(content::RenderFrame* render_frame)
     : content::RenderFrameObserver(render_frame),
       content::RenderFrameObserverTracker<SearchBox>(render_frame),
       page_seq_no_(0),
       is_focused_(false),
       is_input_in_progress_(false),
       is_key_capture_enabled_(false),
       most_visited_items_cache_(kMaxInstantMostVisitedItemCacheSize),
-      query_(),
       binding_(this) {
   // Connect to the embedded search interface in the browser.
   chrome::mojom::EmbeddedSearchConnectorAssociatedPtr connector;
   render_frame->GetRemoteAssociatedInterfaces()->GetInterface(&connector);
   chrome::mojom::SearchBoxAssociatedPtrInfo search_box;
   binding_.Bind(mojo::MakeRequest(&search_box));
   connector->Connect(mojo::MakeRequest(&instant_service_),
                      std::move(search_box));
 }
 
@@ skipping 162 matching lines @@
   }
 }
 
 void SearchBox::SetSuggestionToPrefetch(const InstantSuggestion& suggestion) {
   suggestion_ = suggestion;
   DVLOG(1) << render_frame() << " SetSuggestionToPrefetch";
   extensions_v8::SearchBoxExtension::DispatchSuggestionChange(
       render_frame()->GetWebFrame());
 }
 
-void SearchBox::Submit(const base::string16& query,
-                       const EmbeddedSearchRequestParams& params) {
-  query_ = query;
+void SearchBox::Submit(const EmbeddedSearchRequestParams& params) {
   embedded_search_request_params_ = params;
   DVLOG(1) << render_frame() << " Submit";
   extensions_v8::SearchBoxExtension::DispatchSubmit(
       render_frame()->GetWebFrame());
-  if (!query.empty())

[Marc Treib, 2017/05/17 08:02:02]

Removing this check looks like a logical change, but in practice, both
BrowserInstantController and InstantSearchPrerenderer make sure the query is
non-empty before starting the chain of Commit/Submit calls.

-    Reset();
+  Reset();
 }
 
 void SearchBox::ThemeChanged(const ThemeBackgroundInfo& theme_info) {
   // Do not send duplicate notifications.
   if (theme_info_ == theme_info)
     return;
 
   theme_info_ = theme_info;
   extensions_v8::SearchBoxExtension::DispatchThemeChange(
       render_frame()->GetWebFrame());
 }
 
 GURL SearchBox::GetURLForMostVisitedItem(InstantRestrictedID item_id) const {
   InstantMostVisitedItem item;
   return GetMostVisitedItemWithID(item_id, &item) ? item.url : GURL();
 }
 
 void SearchBox::Bind(chrome::mojom::SearchBoxAssociatedRequest request) {
   binding_.Bind(std::move(request));
 }
 
 void SearchBox::Reset() {
-  query_.clear();
   embedded_search_request_params_ = EmbeddedSearchRequestParams();
   suggestion_ = InstantSuggestion();
   is_focused_ = false;
   is_key_capture_enabled_ = false;
   theme_info_ = ThemeBackgroundInfo();
 }
 
 void SearchBox::OnDestruct() {
   delete this;
 }