Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6953)

Unified Diff: chrome/renderer/searchbox/searchbox.cc

Issue 2884293002: Remove unused embeddedSearch.searchBox APIs (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/searchbox/searchbox.h ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/searchbox/searchbox.cc
diff --git a/chrome/renderer/searchbox/searchbox.cc b/chrome/renderer/searchbox/searchbox.cc
index 463e13c58b657cae15e9e592b6e1447533a652e0..035d81af20979302a754b9d9253c18aab37fc275 100644
--- a/chrome/renderer/searchbox/searchbox.cc
+++ b/chrome/renderer/searchbox/searchbox.cc
@@ -229,7 +229,6 @@ SearchBox::SearchBox(content::RenderFrame* render_frame)
is_input_in_progress_(false),
is_key_capture_enabled_(false),
most_visited_items_cache_(kMaxInstantMostVisitedItemCacheSize),
- query_(),
binding_(this) {
// Connect to the embedded search interface in the browser.
chrome::mojom::EmbeddedSearchConnectorAssociatedPtr connector;
@@ -412,15 +411,12 @@ void SearchBox::SetSuggestionToPrefetch(const InstantSuggestion& suggestion) {
render_frame()->GetWebFrame());
}
-void SearchBox::Submit(const base::string16& query,
- const EmbeddedSearchRequestParams& params) {
- query_ = query;
+void SearchBox::Submit(const EmbeddedSearchRequestParams& params) {
embedded_search_request_params_ = params;
DVLOG(1) << render_frame() << " Submit";
extensions_v8::SearchBoxExtension::DispatchSubmit(
render_frame()->GetWebFrame());
- if (!query.empty())
Marc Treib 2017/05/17 08:02:02 Removing this check looks like a logical change, b
- Reset();
+ Reset();
}
void SearchBox::ThemeChanged(const ThemeBackgroundInfo& theme_info) {
@@ -443,7 +439,6 @@ void SearchBox::Bind(chrome::mojom::SearchBoxAssociatedRequest request) {
}
void SearchBox::Reset() {
- query_.clear();
embedded_search_request_params_ = EmbeddedSearchRequestParams();
suggestion_ = InstantSuggestion();
is_focused_ = false;
« no previous file with comments | « chrome/renderer/searchbox/searchbox.h ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698