Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2884263002: NodeFilter#acceptNode argument node should not be optional (Closed)

Created:
3 years, 7 months ago by Tripta
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

NodeFilter#acceptNode argument node should not be optional BUG=701567 Review-Url: https://codereview.chromium.org/2884263002 Cr-Commit-Position: refs/heads/master@{#473486} Committed: https://chromium.googlesource.com/chromium/src/+/b2785c18771b5327f278df28152d1b9ae5b9ce98

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removing the FIXME comment #

Total comments: 1

Patch Set 3 : Removed [Default=Undefined] for node argument. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeFilter.idl View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 32 (23 generated)
Tripta
3 years, 7 months ago (2017-05-17 07:18:38 UTC) #7
suchit.agrawal
https://codereview.chromium.org/2884263002/diff/1/third_party/WebKit/Source/core/dom/NodeFilter.idl File third_party/WebKit/Source/core/dom/NodeFilter.idl (right): https://codereview.chromium.org/2884263002/diff/1/third_party/WebKit/Source/core/dom/NodeFilter.idl#newcode49 third_party/WebKit/Source/core/dom/NodeFilter.idl:49: // FIXME: The node argument should not be optional. ...
3 years, 7 months ago (2017-05-18 07:06:38 UTC) #9
Tripta
3 years, 7 months ago (2017-05-19 07:13:27 UTC) #15
tkent
https://codereview.chromium.org/2884263002/diff/20001/third_party/WebKit/Source/core/dom/NodeFilter.idl File third_party/WebKit/Source/core/dom/NodeFilter.idl (right): https://codereview.chromium.org/2884263002/diff/20001/third_party/WebKit/Source/core/dom/NodeFilter.idl#newcode49 third_party/WebKit/Source/core/dom/NodeFilter.idl:49: [RaisesException] unsigned short acceptNode([Default=Undefined] Node node); Please remove [Default=Undefined] ...
3 years, 7 months ago (2017-05-19 07:18:47 UTC) #16
Tripta
Have removed [Default=Undefined] for node argument. Please review the code.
3 years, 7 months ago (2017-05-19 09:48:09 UTC) #21
Tripta
On 2017/05/19 07:18:47, tkent wrote: > https://codereview.chromium.org/2884263002/diff/20001/third_party/WebKit/Source/core/dom/NodeFilter.idl > File third_party/WebKit/Source/core/dom/NodeFilter.idl (right): > > https://codereview.chromium.org/2884263002/diff/20001/third_party/WebKit/Source/core/dom/NodeFilter.idl#newcode49 > ...
3 years, 7 months ago (2017-05-19 09:49:18 UTC) #22
tkent
lgtm
3 years, 7 months ago (2017-05-21 21:24:14 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884263002/40001
3 years, 7 months ago (2017-05-21 21:24:25 UTC) #29
commit-bot: I haz the power
3 years, 7 months ago (2017-05-21 22:53:44 UTC) #32
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b2785c18771b5327f278df28152d...

Powered by Google App Engine
This is Rietveld 408576698