Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2884263002:
NodeFilter#acceptNode argument node should not be optional (Closed)
DescriptionNodeFilter#acceptNode argument node should not be optional
BUG=701567
Review-Url: https://codereview.chromium.org/2884263002
Cr-Commit-Position: refs/heads/master@{#473486}
Committed: https://chromium.googlesource.com/chromium/src/+/b2785c18771b5327f278df28152d1b9ae5b9ce98
Patch Set 1 #
Total comments: 1
Patch Set 2 : Removing the FIXME comment #
Total comments: 1
Patch Set 3 : Removed [Default=Undefined] for node argument. #Messages
Total messages: 32 (23 generated)
The CQ bit was checked by tripta.g@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== NodeFilter#acceptNode argument node should not be optional BUG=701567 ========== to ========== NodeFilter#acceptNode argument node should not be optional BUG=701567 ==========
tripta.g@samsung.com changed reviewers: + a.suchit@samsung.com
suchit.agrawal@gmail.com changed reviewers: + suchit.agrawal@gmail.com
https://codereview.chromium.org/2884263002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/NodeFilter.idl (right): https://codereview.chromium.org/2884263002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/NodeFilter.idl:49: // FIXME: The node argument should not be optional. remove FIXME.
The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tripta.g@samsung.com changed reviewers: + tkent@chromium.org
https://codereview.chromium.org/2884263002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/dom/NodeFilter.idl (right): https://codereview.chromium.org/2884263002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/dom/NodeFilter.idl:49: [RaisesException] unsigned short acceptNode([Default=Undefined] Node node); Please remove [Default=Undefined] too. It's an extended attribute for an optional argument.
The CQ bit was checked by tripta.g@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Have removed [Default=Undefined] for node argument. Please review the code.
On 2017/05/19 07:18:47, tkent wrote: > https://codereview.chromium.org/2884263002/diff/20001/third_party/WebKit/Sour... > File third_party/WebKit/Source/core/dom/NodeFilter.idl (right): > > https://codereview.chromium.org/2884263002/diff/20001/third_party/WebKit/Sour... > third_party/WebKit/Source/core/dom/NodeFilter.idl:49: [RaisesException] unsigned > short acceptNode([Default=Undefined] Node node); > Please remove [Default=Undefined] too. It's an extended attribute for an > optional argument. Done. Please review the code.
The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by tkent@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495401853924470,
"parent_rev": "5200a050cd3a47af602de882ad2927b6af05c310", "commit_rev":
"b2785c18771b5327f278df28152d1b9ae5b9ce98"}
Message was sent while issue was closed.
Description was changed from ========== NodeFilter#acceptNode argument node should not be optional BUG=701567 ========== to ========== NodeFilter#acceptNode argument node should not be optional BUG=701567 Review-Url: https://codereview.chromium.org/2884263002 Cr-Commit-Position: refs/heads/master@{#473486} Committed: https://chromium.googlesource.com/chromium/src/+/b2785c18771b5327f278df28152d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/b2785c18771b5327f278df28152d... |
