third_party/WebKit/Source/core/dom/NodeFilter.idl - Issue 2884263002: NodeFilter#acceptNode argument node should not be optional

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/dom/NodeFilter.idl

Issue 2884263002: NodeFilter#acceptNode argument node should not be optional (Closed)

Patch Set: Removing the FIXME comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.

3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>	3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>

4 *	4 *

5 * This library is free software; you can redistribute it and/or	5 * This library is free software; you can redistribute it and/or

6 * modify it under the terms of the GNU Library General Public	6 * modify it under the terms of the GNU Library General Public

7 * License as published by the Free Software Foundation; either	7 * License as published by the Free Software Foundation; either

8 * version 2 of the License, or (at your option) any later version.	8 * version 2 of the License, or (at your option) any later version.

9 *	9 *

10 * This library is distributed in the hope that it will be useful,	10 * This library is distributed in the hope that it will be useful,

(...skipping 28 matching lines...) Expand all Loading...
39 const unsigned long SHOW_PROCESSING_INSTRUCTION = 0x40;	39 const unsigned long SHOW_PROCESSING_INSTRUCTION = 0x40;

40 const unsigned long SHOW_COMMENT = 0x80;	40 const unsigned long SHOW_COMMENT = 0x80;

41 const unsigned long SHOW_DOCUMENT = 0x100;	41 const unsigned long SHOW_DOCUMENT = 0x100;

42 const unsigned long SHOW_DOCUMENT_TYPE = 0x200;	42 const unsigned long SHOW_DOCUMENT_TYPE = 0x200;

43 const unsigned long SHOW_DOCUMENT_FRAGMENT = 0x400;	43 const unsigned long SHOW_DOCUMENT_FRAGMENT = 0x400;

44 const unsigned long SHOW_NOTATION = 0x800; // historical	44 const unsigned long SHOW_NOTATION = 0x800; // historical

45	45

46 // This function declaration doesn't generate any code because	46 // This function declaration doesn't generate any code because

47 // V8NodeFilterCondition represents this callback interface in Blink.	47 // V8NodeFilterCondition represents this callback interface in Blink.

48 // TODO(bashi): Fix crbug.com/630986, and use generated code.	48 // TODO(bashi): Fix crbug.com/630986, and use generated code.

49 // FIXME: The node argument should not be optional.	49 [RaisesException] unsigned short acceptNode([Default=Undefined] Node node);
	tkent 2017/05/19 07:18:47 Please remove [Default=Undefined] too. It's an ex Please remove [Default=Undefined] too. It's an extended attribute for an optional argument.
50 [RaisesException] unsigned short acceptNode([Default=Undefined] optional Nod e node);

51 };	50 };

OLD	NEW