Revert of build: Enable optimize_for_size unconditionally.

Revert of build: Enable optimize_for_size unconditionally. (patchset #1 id:1 of https://codereview.chromium.org/2870393005/ )

Reason for revert:
Large number of perf regressions on mac.

BUG=722473
Original issue's description:
> Reland of build: Enable optimize_for_size unconditionally. (patchset #1 id:1 of https://codereview.chromium.org/2881503002/ )
> 
> Reason for revert:
> Relanding now that the msan issue is fixed: https://codereview.chromium.org/2876693003
> 
> Original issue's description:
> > Revert of build: Enable optimize_for_size unconditionally. (patchset #1 id:1 of https://codereview.chromium.org/2864383003/ )
> > 
> > Reason for revert:
> > Causes failures on a MSAN bot.
> > https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/440
> > 
> > 
> > Original issue's description:
> > > build: Enable optimize_for_size unconditionally.
> > > 
> > > This change causes us to favor size over speed on Linux and Mac,
> > > which aligns the build config for those platforms with that of the
> > > other supported platforms, and should reduce the binary size impact
> > > of enabling ThinLTO. This change is expected to reduce binary size
> > > for Linux official builds by about 15%.
> > > 
> > > There may be unacceptable perf regressions associated with this
> > > change, but the perf bots should at least let us know where those
> > > regressions are. I plan to monitor the Linux and Mac perf bots once
> > > it lands.
> > > 
> > > BUG=660216
> > > R=thakis@chromium.org
> > > 
> > > Review-Url: https://codereview.chromium.org/2864383003
> > > Cr-Commit-Position: refs/heads/master@{#470606}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/c1269ce7fec8568a1789e07b2b5bb3b630a67f5f
> > 
> > TBR=thakis@chromium.org,pcc@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=660216
> > 
> > Review-Url: https://codereview.chromium.org/2881503002
> > Cr-Commit-Position: refs/heads/master@{#470793}
> > Committed: https://chromium.googlesource.com/chromium/src/+/2a6f440fa84a584d916254f9a4c4e4d83c53435f
> 
> TBR=thakis@chromium.org,yhirano@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=660216
> 
> Review-Url: https://codereview.chromium.org/2870393005
> Cr-Commit-Position: refs/heads/master@{#471046}
> Committed: https://chromium.googlesource.com/chromium/src/+/ea5fad44dd0b0a74a40dbe2c05598f43861cd75a

TBR=thakis@chromium.org,yhirano@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=660216
Review-Url: https://codereview.chromium.org/2883113002
Cr-Commit-Position: refs/heads/master@{#472010}
Committed: https://chromium.googlesource.com/chromium/src/+/22667180463b25a9059df17350b495b037e5a300

[pcc1, 2017-05-15 19:58:11]

The CQ bit was checked by pcc@chromium.org

[pcc1, 2017-05-15 19:58:11]

Created Revert of build: Enable optimize_for_size unconditionally.

[commit-bot: I haz the power, 2017-05-15 19:59:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-05-15 20:00:54]

lgtm

Do you have a list of impacted metrics somewhere? Did they regress only on mac
or also on linux?

[pcc1, 2017-05-15 20:04:14]

On 2017/05/15 20:00:54, Nico wrote:
> lgtm
> 
> Do you have a list of impacted metrics somewhere? Did they regress only on mac
> or also on linux?

Yes, https://chromeperf.appspot.com/group_report?rev=471046

This report shows many more regressions on Mac than on Linux, but I spot checked
the Linux perf graphs for media_perftests and saw similar regressions. It may
simply be that we have less monitoring for Linux than we do for Mac.

[commit-bot: I haz the power, 2017-05-15 20:32:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 20:32:39]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pcc1, 2017-05-15 20:45:53]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2017-05-15 20:47:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 02:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:57:44]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pcc1, 2017-05-16 02:58:41]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:59:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 03:58:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494903521195060, "parent_rev":
"f13aaab4c0c1c0c03fa8f3c2d62291f1a2c12e68", "commit_rev":
"22667180463b25a9059df17350b495b037e5a300"}

[commit-bot: I haz the power, 2017-05-16 03:58:27]

Description was changed from

==========
Revert of build: Enable optimize_for_size unconditionally. (patchset #1 id:1 of
https://codereview.chromium.org/2870393005/ )

Reason for revert:
Large number of perf regressions on mac.

BUG=722473

Original issue's description:
> Reland of build: Enable optimize_for_size unconditionally. (patchset #1 id:1
of https://codereview.chromium.org/2881503002/ )
> 
> Reason for revert:
> Relanding now that the msan issue is fixed:
https://codereview.chromium.org/2876693003
> 
> Original issue's description:
> > Revert of build: Enable optimize_for_size unconditionally. (patchset #1 id:1
of https://codereview.chromium.org/2864383003/ )
> > 
> > Reason for revert:
> > Causes failures on a MSAN bot.
> >
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...
> > 
> > 
> > Original issue's description:
> > > build: Enable optimize_for_size unconditionally.
> > > 
> > > This change causes us to favor size over speed on Linux and Mac,
> > > which aligns the build config for those platforms with that of the
> > > other supported platforms, and should reduce the binary size impact
> > > of enabling ThinLTO. This change is expected to reduce binary size
> > > for Linux official builds by about 15%.
> > > 
> > > There may be unacceptable perf regressions associated with this
> > > change, but the perf bots should at least let us know where those
> > > regressions are. I plan to monitor the Linux and Mac perf bots once
> > > it lands.
> > > 
> > > BUG=660216
> > > R=thakis@chromium.org
> > > 
> > > Review-Url: https://codereview.chromium.org/2864383003
> > > Cr-Commit-Position: refs/heads/master@{#470606}
> > > Committed:
https://chromium.googlesource.com/chromium/src/+/c1269ce7fec8568a1789e07b2b5b...
> > 
> > TBR=thakis@chromium.org,pcc@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=660216
> > 
> > Review-Url: https://codereview.chromium.org/2881503002
> > Cr-Commit-Position: refs/heads/master@{#470793}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/2a6f440fa84a584d916254f9a4c4...
> 
> TBR=thakis@chromium.org,yhirano@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=660216
> 
> Review-Url: https://codereview.chromium.org/2870393005
> Cr-Commit-Position: refs/heads/master@{#471046}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ea5fad44dd0b0a74a40dbe2c0559...

TBR=thakis@chromium.org,yhirano@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=660216
==========

to

==========
Revert of build: Enable optimize_for_size unconditionally. (patchset #1 id:1 of
https://codereview.chromium.org/2870393005/ )

Reason for revert:
Large number of perf regressions on mac.

BUG=722473

Original issue's description:
> Reland of build: Enable optimize_for_size unconditionally. (patchset #1 id:1
of https://codereview.chromium.org/2881503002/ )
> 
> Reason for revert:
> Relanding now that the msan issue is fixed:
https://codereview.chromium.org/2876693003
> 
> Original issue's description:
> > Revert of build: Enable optimize_for_size unconditionally. (patchset #1 id:1
of https://codereview.chromium.org/2864383003/ )
> > 
> > Reason for revert:
> > Causes failures on a MSAN bot.
> >
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...
> > 
> > 
> > Original issue's description:
> > > build: Enable optimize_for_size unconditionally.
> > > 
> > > This change causes us to favor size over speed on Linux and Mac,
> > > which aligns the build config for those platforms with that of the
> > > other supported platforms, and should reduce the binary size impact
> > > of enabling ThinLTO. This change is expected to reduce binary size
> > > for Linux official builds by about 15%.
> > > 
> > > There may be unacceptable perf regressions associated with this
> > > change, but the perf bots should at least let us know where those
> > > regressions are. I plan to monitor the Linux and Mac perf bots once
> > > it lands.
> > > 
> > > BUG=660216
> > > R=thakis@chromium.org
> > > 
> > > Review-Url: https://codereview.chromium.org/2864383003
> > > Cr-Commit-Position: refs/heads/master@{#470606}
> > > Committed:
https://chromium.googlesource.com/chromium/src/+/c1269ce7fec8568a1789e07b2b5b...
> > 
> > TBR=thakis@chromium.org,pcc@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=660216
> > 
> > Review-Url: https://codereview.chromium.org/2881503002
> > Cr-Commit-Position: refs/heads/master@{#470793}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/2a6f440fa84a584d916254f9a4c4...
> 
> TBR=thakis@chromium.org,yhirano@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=660216
> 
> Review-Url: https://codereview.chromium.org/2870393005
> Cr-Commit-Position: refs/heads/master@{#471046}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ea5fad44dd0b0a74a40dbe2c0559...

TBR=thakis@chromium.org,yhirano@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=660216

Review-Url: https://codereview.chromium.org/2883113002
Cr-Commit-Position: refs/heads/master@{#472010}
Committed:
https://chromium.googlesource.com/chromium/src/+/22667180463b25a9059df17350b4...
==========

[commit-bot: I haz the power, 2017-05-16 03:58:29]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/22667180463b25a9059df17350b4...