Update FlatBuffers to include multiple improvements.

Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.
 - aaf5598: Fix path comparison on Windows.
 - fb87c0d: Improve allocator handling (fixes test).
 - 22743ca: Fix --keep-prefix bugs.
 - 642254b: Fix one more --keep-prefix issue.
 - dd05f32: Add tests for nested FlatBuffers.
 - 01c50d5: Get rid of move semantics in VectorIterator.

BUG=611351, 713774
Review-Url: https://codereview.chromium.org/2883063002
Cr-Commit-Position: refs/heads/master@{#477254}
Committed: https://chromium.googlesource.com/chromium/src/+/387b2a94017449569f0f5b2f865d3331e3646a3a

[pkalinnikov, 2017-05-15 16:35:48]

The CQ bit was checked by pkalinnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 16:36:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkalinnikov, 2017-05-15 16:39:14]

Description was changed from

==========
Update FlatBuffers to include multiple improvements.

BUG=
==========

to

==========
Update FlatBuffers to include multiple improvements.

BUG=611351
==========

[pkalinnikov, 2017-05-15 16:39:45]

Description was changed from

==========
Update FlatBuffers to include multiple improvements.

BUG=611351
==========

to

==========
Update FlatBuffers to include multiple improvements.

BUG=611351,713774
==========

[commit-bot: I haz the power, 2017-05-15 17:42:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 17:42:45]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[pkalinnikov, 2017-05-16 09:12:38]

The CQ bit was checked by pkalinnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 09:13:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkalinnikov, 2017-05-16 09:33:07]

Description was changed from

==========
Update FlatBuffers to include multiple improvements.

BUG=611351,713774
==========

to

==========
Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.

BUG=611351,713774
==========

[pkalinnikov, 2017-05-16 09:57:37]

pkalinnikov@chromium.org changed reviewers:
+ engedy@chromium.org, palmer@chromium.org

[pkalinnikov, 2017-05-16 09:57:38]

Balazs and Chris, PTAL.

Please disregard crrev/2740103002, I will address crbug/699958 separately from
updating FlatBuffers.

[commit-bot: I haz the power, 2017-05-16 10:22:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 10:22:11]

Dry run: This issue passed the CQ dry run.

[engedy, 2017-05-16 11:18:33]

LGTM.

[palmer, 2017-05-16 22:14:42]

https://codereview.chromium.org/2883063002/diff/20001/third_party/flatbuffers...
File third_party/flatbuffers/BUILD.gn (right):

https://codereview.chromium.org/2883063002/diff/20001/third_party/flatbuffers...
third_party/flatbuffers/BUILD.gn:108: "FLATBUFFERS_NO_FILE_TESTS",
Can you characterize the tests and the crashes? Any chance there's security
implication there? (Memory corruption?)

[pkalinnikov, 2017-05-18 14:58:43]

The CQ bit was checked by pkalinnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 14:59:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 16:17:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 16:17:09]

Dry run: This issue passed the CQ dry run.

[pkalinnikov, 2017-05-19 11:16:46]

The CQ bit was checked by pkalinnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 11:17:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkalinnikov, 2017-05-19 11:18:27]

Description was changed from

==========
Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.

BUG=611351,713774
==========

to

==========
Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.
 - aaf5598: Fix path comparison on Windows.

BUG=611351,713774
==========

[commit-bot: I haz the power, 2017-05-19 13:11:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 13:11:19]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pkalinnikov, 2017-05-26 10:37:38]

The CQ bit was checked by pkalinnikov@chromium.org to run a CQ dry run

[pkalinnikov, 2017-05-26 10:37:46]

Description was changed from

==========
Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.
 - aaf5598: Fix path comparison on Windows.

BUG=611351,713774
==========

to

==========
Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.
 - aaf5598: Fix path comparison on Windows.
 - fb87c0d: Improve allocator handling (fixes test).
 - 22743ca: Fix --keep-prefix bugs.

BUG=611351,713774
==========

[commit-bot: I haz the power, 2017-05-26 10:37:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkalinnikov, 2017-05-26 11:30:24]

https://codereview.chromium.org/2883063002/diff/20001/third_party/flatbuffers...
File third_party/flatbuffers/BUILD.gn (right):

https://codereview.chromium.org/2883063002/diff/20001/third_party/flatbuffers...
third_party/flatbuffers/BUILD.gn:108: "FLATBUFFERS_NO_FILE_TESTS",
On 2017/05/16 22:14:42, palmer wrote:
> Can you characterize the tests and the crashes? Any chance there's security
> implication there? (Memory corruption?)

I was running this test incorrectly. It actually works. Removed this clause.

[commit-bot: I haz the power, 2017-05-26 12:26:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 12:26:31]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[palmer, 2017-05-30 20:18:52]

lgtm

[pkalinnikov, 2017-06-06 09:27:08]

The CQ bit was checked by pkalinnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 09:27:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkalinnikov, 2017-06-06 09:30:26]

Description was changed from

==========
Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.
 - aaf5598: Fix path comparison on Windows.
 - fb87c0d: Improve allocator handling (fixes test).
 - 22743ca: Fix --keep-prefix bugs.

BUG=611351,713774
==========

to

==========
Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.
 - aaf5598: Fix path comparison on Windows.
 - fb87c0d: Improve allocator handling (fixes test).
 - 22743ca: Fix --keep-prefix bugs.
 - 642254b: Fix one more --keep-prefix issue.
 - dd05f32: Add tests for nested FlatBuffers.
 - 01c50d5: Get rid of move semantics in VectorIterator.

BUG=611351,713774
==========

[pkalinnikov, 2017-06-06 09:31:36]

Description was changed from

==========
Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.
 - aaf5598: Fix path comparison on Windows.
 - fb87c0d: Improve allocator handling (fixes test).
 - 22743ca: Fix --keep-prefix bugs.
 - 642254b: Fix one more --keep-prefix issue.
 - dd05f32: Add tests for nested FlatBuffers.
 - 01c50d5: Get rid of move semantics in VectorIterator.

BUG=611351,713774
==========

to

==========
Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.
 - aaf5598: Fix path comparison on Windows.
 - fb87c0d: Improve allocator handling (fixes test).
 - 22743ca: Fix --keep-prefix bugs.
 - 642254b: Fix one more --keep-prefix issue.
 - dd05f32: Add tests for nested FlatBuffers.
 - 01c50d5: Get rid of move semantics in VectorIterator.

TBR=palmer@chromium.org
BUG=611351,713774
==========

[pkalinnikov, 2017-06-06 09:33:15]

Balazs, can you take a final look? This is ready to be submitted.

[engedy, 2017-06-06 09:39:35]

On 2017/06/06 09:33:15, pkalinnikov wrote:
> Balazs, can you take a final look? This is ready to be submitted.

Still (mostly rubberstamp) LGTM.

[commit-bot: I haz the power, 2017-06-06 10:41:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 10:41:44]

Dry run: This issue passed the CQ dry run.

[pkalinnikov, 2017-06-06 10:42:18]

Description was changed from

==========
Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.
 - aaf5598: Fix path comparison on Windows.
 - fb87c0d: Improve allocator handling (fixes test).
 - 22743ca: Fix --keep-prefix bugs.
 - 642254b: Fix one more --keep-prefix issue.
 - dd05f32: Add tests for nested FlatBuffers.
 - 01c50d5: Get rid of move semantics in VectorIterator.

TBR=palmer@chromium.org
BUG=611351,713774
==========

to

==========
Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.
 - aaf5598: Fix path comparison on Windows.
 - fb87c0d: Improve allocator handling (fixes test).
 - 22743ca: Fix --keep-prefix bugs.
 - 642254b: Fix one more --keep-prefix issue.
 - dd05f32: Add tests for nested FlatBuffers.
 - 01c50d5: Get rid of move semantics in VectorIterator.

BUG=611351,713774
==========

[pkalinnikov, 2017-06-06 10:42:26]

The CQ bit was checked by pkalinnikov@chromium.org

[pkalinnikov, 2017-06-06 10:42:26]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org
Link to the patchset: https://codereview.chromium.org/2883063002/#ps80001
(title: "Upgrade further.")

[commit-bot: I haz the power, 2017-06-06 10:42:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 10:47:40]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496745746062920,
"parent_rev": "d99a9664c873fc38e226e33bc92da974fb852da3", "commit_rev":
"387b2a94017449569f0f5b2f865d3331e3646a3a"}

[commit-bot: I haz the power, 2017-06-06 10:48:01]

Description was changed from

==========
Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.
 - aaf5598: Fix path comparison on Windows.
 - fb87c0d: Improve allocator handling (fixes test).
 - 22743ca: Fix --keep-prefix bugs.
 - 642254b: Fix one more --keep-prefix issue.
 - dd05f32: Add tests for nested FlatBuffers.
 - 01c50d5: Get rid of move semantics in VectorIterator.

BUG=611351,713774
==========

to

==========
Update FlatBuffers to include multiple improvements.

This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to
include the following changes to the library:
 - d7ac378: Offset<T>::IsNull method.
 - 93c0960: --keep-prefix compiler option.
 - c559eb4: Generate files for empty schemas.
 - aaf5598: Fix path comparison on Windows.
 - fb87c0d: Improve allocator handling (fixes test).
 - 22743ca: Fix --keep-prefix bugs.
 - 642254b: Fix one more --keep-prefix issue.
 - dd05f32: Add tests for nested FlatBuffers.
 - 01c50d5: Get rid of move semantics in VectorIterator.

BUG=611351,713774

Review-Url: https://codereview.chromium.org/2883063002
Cr-Commit-Position: refs/heads/master@{#477254}
Committed:
https://chromium.googlesource.com/chromium/src/+/387b2a94017449569f0f5b2f865d...
==========

[commit-bot: I haz the power, 2017-06-06 10:48:01]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/387b2a94017449569f0f5b2f865d...

[pkalinnikov, 2017-06-06 11:32:27]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2926563002/ by pkalinnikov@chromium.org.

The reason for reverting is: Fails "Win" build:
https://build.chromium.org/p/chromium/builders/Win/builds/55836.

[findit-for-me, 2017-06-06 11:48:21]

Findit (https://goo.gl/kROfz5) confirmed this CL at revision 477254 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...