Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2928573002: [flatbuffers] Enable including by absolute path. (Closed)

Created:
3 years, 6 months ago by pkalinnikov
Modified:
3 years, 6 months ago
CC:
chromium-reviews, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[flatbuffers] Enable including by absolute path. BUG=713774 Review-Url: https://codereview.chromium.org/2928573002 Cr-Commit-Position: refs/heads/master@{#478130} Committed: https://chromium.googlesource.com/chromium/src/+/7975d5b8c41a7f2239f3cf9f537549795a74a815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M components/subresource_filter/core/common/flat/indexed_ruleset.fbs View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/flatbuffers/flatbuffer.gni View 2 chunks +16 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
pkalinnikov
Karan and Charlie, PTAL.
3 years, 6 months ago (2017-06-06 10:53:23 UTC) #5
Charlie Harrison
LGTM
3 years, 6 months ago (2017-06-06 12:17:10 UTC) #8
karandeepb
LGTM
3 years, 6 months ago (2017-06-06 18:35:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928573002/1
3 years, 6 months ago (2017-06-08 22:50:14 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 00:11:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7975d5b8c41a7f2239f3cf9f5375...

Powered by Google App Engine
This is Rietveld 408576698