Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2926563002: Revert of Update FlatBuffers to include multiple improvements. (Closed)

Created:
3 years, 6 months ago by pkalinnikov
Modified:
3 years, 6 months ago
Reviewers:
palmer, engedy
CC:
chromium-reviews, vabr (Chromium)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update FlatBuffers to include multiple improvements. (patchset #5 id:80001 of https://codereview.chromium.org/2883063002/ ) Reason for revert: Fails "Win" build: https://build.chromium.org/p/chromium/builders/Win/builds/55836 Original issue's description: > Update FlatBuffers to include multiple improvements. > > This CL updates FlatBuffers to the latest version 1.6.x. This is necessary to > include the following changes to the library: > - d7ac378: Offset<T>::IsNull method. > - 93c0960: --keep-prefix compiler option. > - c559eb4: Generate files for empty schemas. > - aaf5598: Fix path comparison on Windows. > - fb87c0d: Improve allocator handling (fixes test). > - 22743ca: Fix --keep-prefix bugs. > - 642254b: Fix one more --keep-prefix issue. > - dd05f32: Add tests for nested FlatBuffers. > - 01c50d5: Get rid of move semantics in VectorIterator. > > BUG=611351, 713774 > > Review-Url: https://codereview.chromium.org/2883063002 > Cr-Commit-Position: refs/heads/master@{#477254} > Committed: https://chromium.googlesource.com/chromium/src/+/387b2a94017449569f0f5b2f865d3331e3646a3a TBR=palmer@chromium.org,engedy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=611351, 713774 Review-Url: https://codereview.chromium.org/2926563002 Cr-Commit-Position: refs/heads/master@{#477258} Committed: https://chromium.googlesource.com/chromium/src/+/10a266981d83baf81c3eb24873c8732699ed087e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -54 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/flatbuffers/BUILD.gn View 4 chunks +12 lines, -25 lines 0 comments Download
M third_party/flatbuffers/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/flatbuffers/flatbuffer.gni View 3 chunks +5 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
pkalinnikov
Created Revert of Update FlatBuffers to include multiple improvements.
3 years, 6 months ago (2017-06-06 11:32:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926563002/1
3 years, 6 months ago (2017-06-06 11:32:36 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 11:33:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/10a266981d83baf81c3eb24873c8...

Powered by Google App Engine
This is Rietveld 408576698