Remove dependency of DateTimeChooserImpl on ChromeClientImpl

Remove dependency of DateTimeChooserImpl on ChromeClientImpl

Remove dependency of DateTimeChooserImpl on ChromeClientImpl, moving
virtual methods into ChromeClient instead.

This also required implementing the methods in EmptyChromeClient.

BUG=708879
Review-Url: https://codereview.chromium.org/2882923002
Cr-Commit-Position: refs/heads/master@{#471701}
Committed: https://chromium.googlesource.com/chromium/src/+/06b9f76225c4771ec0f2807dde44ae2d46ddead7

[sashab, 2017-05-15 03:00:09]

sashab@chromium.org changed reviewers:
+ slangley@chromium.org

[sashab, 2017-05-15 03:00:12]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 03:00:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[slangley, 2017-05-15 03:38:39]

lgtm

[sashab, 2017-05-15 03:39:27]

sashab@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2017-05-15 04:04:52]

https://codereview.chromium.org/2882923002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/EmptyClients.cpp (right):

https://codereview.chromium.org/2882923002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/EmptyClients.cpp:110: return new
EmptyPagePopup();
Can we just return nullptr here?

[commit-bot: I haz the power, 2017-05-15 04:45:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 04:45:11]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sashab, 2017-05-15 05:23:32]

This removed all changes to EmptyClients.cpp.

https://codereview.chromium.org/2882923002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/EmptyClients.cpp (right):

https://codereview.chromium.org/2882923002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/EmptyClients.cpp:110: return new
EmptyPagePopup();
On 2017/05/15 at 04:04:51, dcheng (in AEST) wrote:
> Can we just return nullptr here?

Good idea; done.

[sashab, 2017-05-15 05:23:36]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 05:23:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-05-15 05:58:44]

LGTM

[commit-bot: I haz the power, 2017-05-15 07:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 07:00:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2017-05-15 07:04:03]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-05-15 07:04:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
slangley@chromium.org
Link to the patchset: https://codereview.chromium.org/2882923002/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2017-05-15 07:04:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 08:42:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494831843846240,
"parent_rev": "3012c22bf47687f565edd7bd2697bb1bf155303c", "commit_rev":
"06b9f76225c4771ec0f2807dde44ae2d46ddead7"}

[commit-bot: I haz the power, 2017-05-15 08:42:55]

Description was changed from

==========
Remove dependency of DateTimeChooserImpl on ChromeClientImpl

Remove dependency of DateTimeChooserImpl on ChromeClientImpl, moving
virtual methods into ChromeClient instead.

This also required implementing the methods in EmptyChromeClient.

BUG=708879
==========

to

==========
Remove dependency of DateTimeChooserImpl on ChromeClientImpl

Remove dependency of DateTimeChooserImpl on ChromeClientImpl, moving
virtual methods into ChromeClient instead.

This also required implementing the methods in EmptyChromeClient.

BUG=708879

Review-Url: https://codereview.chromium.org/2882923002
Cr-Commit-Position: refs/heads/master@{#471701}
Committed:
https://chromium.googlesource.com/chromium/src/+/06b9f76225c4771ec0f2807dde44...
==========

[commit-bot: I haz the power, 2017-05-15 08:42:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/06b9f76225c4771ec0f2807dde44...