Remove dependency of DateTimeChooserImpl on ChromeClientImpl

third_party/WebKit/Source/core/loader/EmptyClients.cpp

 /*
  * Copyright (C) 2006 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009, 2012 Apple Inc. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 17 matching lines @@
 #include "core/loader/EmptyClients.h"
 
 #include <memory>
 #include "core/frame/ContentSettingsClient.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/VisualViewport.h"
 #include "core/html/HTMLFormElement.h"
 #include "core/html/forms/ColorChooser.h"
 #include "core/html/forms/DateTimeChooser.h"
 #include "core/loader/DocumentLoader.h"
+#include "core/page/PagePopup.h"
 #include "platform/FileChooser.h"
 #include "platform/wtf/PtrUtil.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebApplicationCacheHost.h"
 #include "public/platform/WebMediaPlayer.h"
 #include "public/platform/modules/serviceworker/WebServiceWorkerProvider.h"
 #include "public/platform/modules/serviceworker/WebServiceWorkerProviderClient.h"
 
 namespace blink {
 
@@ skipping 13 matching lines @@
 }
 
 class EmptyPopupMenu : public PopupMenu {
  public:
   void Show() override {}
   void Hide() override {}
   void UpdateFromElement(UpdateReason) override {}
   void DisconnectClient() override {}
 };
 
+class EmptyPagePopup : public PagePopup {
+ public:
+  AXObject* RootAXObject() override { return nullptr; }
+  void SetWindowRect(const IntRect&) override {}
+  void PostMessage(const String&) override {}
+};
+
 class EmptyFrameScheduler : public WebFrameScheduler {
  public:
   EmptyFrameScheduler() { DCHECK(IsMainThread()); }
   void SetFrameVisible(bool) override {}
   RefPtr<WebTaskRunner> LoadingTaskRunner() override;
   RefPtr<WebTaskRunner> TimerTaskRunner() override;
   RefPtr<WebTaskRunner> UnthrottledTaskRunner() override;
   RefPtr<WebTaskRunner> SuspendableTaskRunner() override;
 };
 
@@ skipping 10 matching lines @@
 }
 
 RefPtr<WebTaskRunner> EmptyFrameScheduler::SuspendableTaskRunner() {
   return Platform::Current()->MainThread()->GetWebTaskRunner();
 }
 
 PopupMenu* EmptyChromeClient::OpenPopupMenu(LocalFrame&, HTMLSelectElement&) {
   return new EmptyPopupMenu();
 }
 
+PagePopup* EmptyChromeClient::OpenPagePopup(PagePopupClient*) {
+  return new EmptyPagePopup();

[dcheng, 2017/05/15 04:04:51]

Can we just return nullptr here?

[sashab, 2017/05/15 05:23:32]

Good idea; done.

+}
+
 ColorChooser* EmptyChromeClient::OpenColorChooser(LocalFrame*,
                                                   ColorChooserClient*,
                                                   const Color&) {
   return nullptr;
 }
 
 DateTimeChooser* EmptyChromeClient::OpenDateTimeChooser(
     DateTimeChooserClient*,
     const DateTimeChooserParameters&) {
   return nullptr;
@@ skipping 95 matching lines @@
 
 std::unique_ptr<WebApplicationCacheHost>
 EmptyLocalFrameClient::CreateApplicationCacheHost(
     WebApplicationCacheHostClient*) {
   return nullptr;
 }
 
 EmptyRemoteFrameClient::EmptyRemoteFrameClient() = default;
 
 }  // namespace blink