third_party/WebKit/Source/web/ChromeClientImpl.h - Issue 2882923002: Remove dependency of DateTimeChooserImpl on ChromeClientImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 2882923002: Remove dependency of DateTimeChooserImpl on ChromeClientImpl (Closed)

Patch Set: Review feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ChromeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.h b/third_party/WebKit/Source/web/ChromeClientImpl.h

index b9fdd2346f4286086628f95673c44774a00f47d4..35748ffbfc0079a34047dea3aa2ba54042a87f2b 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.h

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.h

@@ -184,8 +184,8 @@ class WEB_EXPORT ChromeClientImpl final : public ChromeClient {

bool HasOpenedPopup() const override;

PopupMenu* OpenPopupMenu(LocalFrame&, HTMLSelectElement&) override;

- PagePopup* OpenPagePopup(PagePopupClient*);

- void ClosePagePopup(PagePopup*);

+ PagePopup* OpenPagePopup(PagePopupClient*) override;

+ void ClosePagePopup(PagePopup*) override;

DOMWindow* PagePopupWindowForTesting() const override;

bool ShouldOpenModalDialogDuringPageDismissal(