Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2882703002: [Sync] Add missing visit to session_id. (Closed)

Created:
3 years, 7 months ago by skym
Modified:
3 years, 7 months ago
Reviewers:
Patrick Noland
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Add missing visit to session_id. Should have been added when the initial proto change was made, see https://chromium.googlesource.com/chromium/src/+/647aa09a706ee13efc535c94698e09559ce6d595%5E%21/#F7 BUG=701032 Review-Url: https://codereview.chromium.org/2882703002 Cr-Commit-Position: refs/heads/master@{#471366} Committed: https://chromium.googlesource.com/chromium/src/+/04c17f56d6af6f1b52ef9418ed4c6bd67305954b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/sync/protocol/proto_visitors.h View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
skym
PTAL
3 years, 7 months ago (2017-05-12 15:58:16 UTC) #5
Patrick Noland
lgtm
3 years, 7 months ago (2017-05-12 16:54:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882703002/1
3 years, 7 months ago (2017-05-12 17:41:58 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 18:06:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/04c17f56d6af6f1b52ef9418ed4c...

Powered by Google App Engine
This is Rietveld 408576698