Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2875203002: UserEvent proto exploration for Translate use case. (Closed)

Created:
3 years, 7 months ago by skym
Modified:
3 years, 6 months ago
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

UserEvent proto exploration for Translate use case. DO NOT SUBMIT BUG=705657

Patch Set 1 #

Patch Set 2 : Adding proto_visitors.h change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -8 lines) Patch
M components/sync/protocol/proto_enum_conversions.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync/protocol/proto_enum_conversions.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M components/sync/protocol/proto_memory_estimations.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M components/sync/protocol/proto_visitors.h View 1 2 chunks +16 lines, -0 lines 0 comments Download
M components/sync/protocol/user_event_specifics.proto View 2 chunks +44 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2882703002 Patch 1

Messages

Total messages: 11 (11 generated)
skym
The CQ bit was checked by skym@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-11 23:36:27 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875203002/1
3 years, 7 months ago (2017-05-11 23:37:45 UTC) #2
skym
Description was changed from ========== Add translate UserEvent protos. BUG=705657 ========== to ========== Add translate ...
3 years, 7 months ago (2017-05-11 23:38:24 UTC) #3
skym
skym@chromium.org changed reviewers: + bartekg@chromium.org, napper@chromium.org, pnoland@chromium.org
3 years, 7 months ago (2017-05-11 23:38:24 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-12 01:27:26 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-05-12 01:27:27 UTC) #6
skym
The CQ bit was checked by skym@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-12 18:03:53 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875203002/20001
3 years, 7 months ago (2017-05-12 18:05:20 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-12 19:46:42 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/292839)
3 years, 7 months ago (2017-05-12 19:46:43 UTC) #10
skym
3 years, 7 months ago (2017-05-12 21:21:35 UTC) #11 
Description was changed from

==========
Add translate UserEvent protos.

BUG=705657
==========

to

==========
UserEvent proto exploration for Translate use case.

DO NOT SUBMIT

BUG=705657
==========

Powered by Google App Engine
This is Rietveld 408576698