UserEvent proto exploration for 0-Suggest use case.

UserEvent proto exploration for 0-Suggest use case.

DO NOT SUBMIT

BUG=417815

[skym, 2017-05-11 23:36:34]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 23:37:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2017-05-11 23:40:40]

Description was changed from

==========
Adding UserEvent protos for 0suggest use cases.

BUG=417815
==========

to

==========
Adding UserEvent protos for 0suggest use cases.

BUG=417815
==========

[skym, 2017-05-11 23:40:40]

skym@chromium.org changed reviewers:
+ bartekg@chromium.org, gcomanici@google.com, pnoland@chromium.org

[commit-bot: I haz the power, 2017-05-12 01:26:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 01:26:21]

Dry run: This issue passed the CQ dry run.

[skym, 2017-05-12 18:04:55]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 18:06:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 19:42:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 19:42:53]

Dry run: This issue passed the CQ dry run.

[skym, 2017-05-12 21:21:36]

Description was changed from

==========
Adding UserEvent protos for 0suggest use cases.

BUG=417815
==========

to

==========
UserEvent proto exploration for 0-Suggest use case.

DO NOT SUBMIT

BUG=417815
==========

[skym, 2017-05-12 21:21:50]

skym@chromium.org changed reviewers:
+ gcomanici@chromium.org
- gcomanici@google.com

[Toyama, 2017-05-16 14:08:34]

kenjitoyama@chromium.org changed reviewers:
+ kenjitoyama@chromium.org

[Toyama, 2017-05-16 14:08:34]

Thanks, Sky, for doing this!

https://codereview.chromium.org/2882443003/diff/20001/components/sync/protoco...
File components/sync/protocol/user_event_specifics.proto (right):

https://codereview.chromium.org/2882443003/diff/20001/components/sync/protoco...
components/sync/protocol/user_event_specifics.proto:30: // The |event_time_usec|
of the ZeroSuggestRequestEvent that generated the
Where is |event_time_usec| defined?

And do you mean s/ZeroSuggestRequestEvent/ZeroSuggestRequest/ ?

[gcomanici, 2017-05-16 14:19:57]

Thank you for this, Sky! In general this looks good, but there is some small
issues with the naming that I would like you to address.

https://codereview.chromium.org/2882443003/diff/20001/components/sync/protoco...
File components/sync/protocol/user_event_specifics.proto (right):

https://codereview.chromium.org/2882443003/diff/20001/components/sync/protoco...
components/sync/protocol/user_event_specifics.proto:16: // Records the event of
0-suggest making a request to cusco and generating
In Chromium code base, this service is known as "experimental contextual
zero-suggest suggestions". We should try to use this instead of cusco, which is
the internal name.

How about "Records requests to the service providing experimental contextual
zero-suggest suggestions."?

https://codereview.chromium.org/2882443003/diff/20001/components/sync/protoco...
components/sync/protocol/user_event_specifics.proto:22: optional int64
cusco_request_id = 1;
We should rename this to contextual_zero_suggest_request_id.

https://codereview.chromium.org/2882443003/diff/20001/components/sync/protoco...
components/sync/protocol/user_event_specifics.proto:32: optional fixed64
request_event_id = 1;
Should the type be int64, for consistency with the event_time_usec it is
referring to? Also, the name is misleading. If we log the time and not the event
id, then the name should be something like "request_event_time_usec".