Create chrome/browser/offline_pages to host browser-related parts of offline_pages whcih

Create chrome/browser/offline_pages to host browser-related parts of offline_pages which
are currently in c/b/android/offline_pages but are not Android-dependent.
This is to avoid mixing of Android-specific code with cross-platform and to
facilitate offline_pages on other platforms (like ChromeOS) in the future.

Also, move the first file there. Tighter DEPS will come in the next CL.

BUG=722467
Review-Url: https://codereview.chromium.org/2881223002
Cr-Commit-Position: refs/heads/master@{#472222}
Committed: https://chromium.googlesource.com/chromium/src/+/d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f

[Dmitry Titov, 2017-05-15 18:30:43]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 18:31:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 19:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 19:41:14]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Dmitry Titov, 2017-05-15 22:10:52]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 22:12:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dmitry Titov, 2017-05-15 22:16:23]

Description was changed from

==========
Create chrome/browser/offline_pages to host browser-related parts of
offlien_pages whcih
are currently in c/b/android/offlien_pages but are not Android-dependent.
This is to avoid mixing of Android-specific code with cross-platform and to
facilitate offline_pages on other platforms (liek ChromeOS) in the future.

BUG=722467
==========

to

==========
Create chrome/browser/offline_pages to host browser-related parts of
offline_pages which
are currently in c/b/android/offlien_pages but are not Android-dependent.
This is to avoid mixing of Android-specific code with cross-platform and to
facilitate offline_pages on other platforms (like ChromeOS) in the future.

Also, move the first file there. Note that proper DEPS will come in the next CL

BUG=722467
==========

[Dmitry Titov, 2017-05-15 22:30:49]

dimich@chromium.org changed reviewers:
+ dewittj@chromium.org

[Dmitry Titov, 2017-05-15 22:32:58]

dimich@chromium.org changed reviewers:
+ sky@chromium.org

[Dmitry Titov, 2017-05-15 22:32:59]

+ sky for c/b/offline_pages creation.

[dewittj, 2017-05-15 22:37:13]

lgtm

https://codereview.chromium.org/2881223002/diff/20001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2881223002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:196: public_deps += [
"//components/offline_pages/core:test_support" ]
hm, I don't know what public_deps is vs deps.

[Dmitry Titov, 2017-05-15 23:23:24]

https://codereview.chromium.org/2881223002/diff/20001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2881223002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:196: public_deps += [
"//components/offline_pages/core:test_support" ]
On 2017/05/15 22:37:13, dewittj wrote:
> hm, I don't know what public_deps is vs deps.

Here is the explanation:
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/referen...

[commit-bot: I haz the power, 2017-05-16 00:05:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 00:05:13]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dewittj, 2017-05-16 00:06:37]

https://codereview.chromium.org/2881223002/diff/20001/chrome/browser/offline_...
File chrome/browser/offline_pages/OWNERS (right):

https://codereview.chromium.org/2881223002/diff/20001/chrome/browser/offline_...
chrome/browser/offline_pages/OWNERS:1: dewittj@chromium.org
can you just write:

file://components/offline_pages/OWNERS

to reduce redundancy?

[Dmitry Titov, 2017-05-16 00:23:39]

On 2017/05/16 00:06:37, dewittj wrote:
>
https://codereview.chromium.org/2881223002/diff/20001/chrome/browser/offline_...
> File chrome/browser/offline_pages/OWNERS (right):
> 
>
https://codereview.chromium.org/2881223002/diff/20001/chrome/browser/offline_...
> chrome/browser/offline_pages/OWNERS:1: mailto:dewittj@chromium.org
> can you just write:
> 
> file://components/offline_pages/OWNERS
> 
> to reduce redundancy?

Good idea, done. 

Also, added a DEPS file to document intent for the next couple of CLs - I'm
going to gradually refactor out the android
dependencies from chrome/browser/android files and move them here.

[Dmitry Titov, 2017-05-16 00:26:50]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 00:27:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dmitry Titov, 2017-05-16 00:33:11]

Description was changed from

==========
Create chrome/browser/offline_pages to host browser-related parts of
offline_pages which
are currently in c/b/android/offlien_pages but are not Android-dependent.
This is to avoid mixing of Android-specific code with cross-platform and to
facilitate offline_pages on other platforms (like ChromeOS) in the future.

Also, move the first file there. Note that proper DEPS will come in the next CL

BUG=722467
==========

to

==========
Create chrome/browser/offline_pages to host browser-related parts of
offline_pages which
are currently in c/b/android/offline_pages but are not Android-dependent.
This is to avoid mixing of Android-specific code with cross-platform and to
facilitate offline_pages on other platforms (like ChromeOS) in the future.

Also, move the first file there. Tighter DEPS will come in the next CL.

BUG=722467
==========

[commit-bot: I haz the power, 2017-05-16 02:07:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:07:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-05-16 12:43:06]

LGTM

[Dmitry Titov, 2017-05-16 15:46:09]

The CQ bit was checked by dimich@chromium.org

[Dmitry Titov, 2017-05-16 15:46:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/2881223002/#ps40001
(title: "modified OWNERS and added DEPS")

[commit-bot: I haz the power, 2017-05-16 15:46:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 18:48:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 18:48:34]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dmitry Titov, 2017-05-16 19:20:17]

The CQ bit was checked by dimich@chromium.org

[commit-bot: I haz the power, 2017-05-16 19:21:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 21:36:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494962417603530,
"parent_rev": "727052688ed51129b6c8fb0cca40d11738a96dcb", "commit_rev":
"d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f"}

[commit-bot: I haz the power, 2017-05-16 21:37:05]

Description was changed from

==========
Create chrome/browser/offline_pages to host browser-related parts of
offline_pages which
are currently in c/b/android/offline_pages but are not Android-dependent.
This is to avoid mixing of Android-specific code with cross-platform and to
facilitate offline_pages on other platforms (like ChromeOS) in the future.

Also, move the first file there. Tighter DEPS will come in the next CL.

BUG=722467
==========

to

==========
Create chrome/browser/offline_pages to host browser-related parts of
offline_pages which
are currently in c/b/android/offline_pages but are not Android-dependent.
This is to avoid mixing of Android-specific code with cross-platform and to
facilitate offline_pages on other platforms (like ChromeOS) in the future.

Also, move the first file there. Tighter DEPS will come in the next CL.

BUG=722467

Review-Url: https://codereview.chromium.org/2881223002
Cr-Commit-Position: refs/heads/master@{#472222}
Committed:
https://chromium.googlesource.com/chromium/src/+/d733a613d2e4faddc4c3a0e5cac9...
==========

[commit-bot: I haz the power, 2017-05-16 21:37:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d733a613d2e4faddc4c3a0e5cac9...