Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2806)

Unified Diff: chrome/test/BUILD.gn

Issue 2881223002: Create chrome/browser/offline_pages to host browser-related parts of offline_pages whcih (Closed)
Patch Set: modified OWNERS and added DEPS Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/offline_pages/background_loader_offliner_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index cb30a724bdc088ee7e45a88c82dab79a5db85c2d..da9ecbd4702125328f0a2a0562c30c42f813da36 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -9,6 +9,7 @@ import("//build/config/features.gni")
import("//build/config/ui.gni")
import("//chrome/common/features.gni")
import("//chrome/chrome_repack_locales.gni")
+import("//components/offline_pages/features/features.gni")
import("//components/os_crypt/features.gni")
import("//components/spellcheck/spellcheck_build_features.gni")
import("//extensions/features/features.gni")
@@ -121,7 +122,6 @@ static_library("test_support") {
"//components/infobars/core",
"//components/metrics:test_support",
"//components/network_time:network_time_test_support",
- "//components/offline_pages/core:test_support",
"//components/omnibox/browser:test_support",
"//components/password_manager/core/browser:test_support",
"//components/prefs:test_support",
@@ -192,6 +192,10 @@ static_library("test_support") {
]
}
+ if (enable_offline_pages) {
+ public_deps += [ "//components/offline_pages/core:test_support" ]
+ }
+
if (is_linux) {
public_deps += [ "//crypto:platform" ]
}
@@ -3416,10 +3420,8 @@ test("unit_tests") {
data += [ "$root_out_dir/Chromium Framework.framework/" ]
}
- if (is_android) {
+ if (enable_offline_pages) {
sources += [
- # Offline pages are currently only on Android.
- "../browser/android/offline_pages/background_loader_offliner_unittest.cc",
"../browser/android/offline_pages/offline_page_mhtml_archiver_unittest.cc",
"../browser/android/offline_pages/offline_page_request_job_unittest.cc",
"../browser/android/offline_pages/offline_page_utils_unittest.cc",
@@ -3431,6 +3433,17 @@ test("unit_tests") {
"../browser/android/offline_pages/test_offline_page_model_builder.h",
"../browser/android/offline_pages/test_request_coordinator_builder.cc",
"../browser/android/offline_pages/test_request_coordinator_builder.h",
+ "../browser/offline_pages/background_loader_offliner_unittest.cc",
+ ]
+ deps += [
+ "//components/offline_pages/content/background_loader:test_support",
+ "//components/offline_pages/core:test_support",
+ "//components/offline_pages/core/background:test_support",
+ ]
+ }
+
+ if (is_android) {
+ sources += [
"../browser/android/search_geolocation/search_geolocation_service_unittest.cc",
"../browser/autofill/autofill_credit_card_filling_infobar_delegate_mobile_unittest.cc",
"../browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc",
@@ -3443,9 +3456,6 @@ test("unit_tests") {
":unit_tests_java",
"//components/gcm_driver/instance_id/android:instance_id_driver_java",
"//components/gcm_driver/instance_id/android:instance_id_driver_test_support_java",
- "//components/offline_pages/content/background_loader:test_support",
- "//components/offline_pages/core:test_support",
- "//components/offline_pages/core/background:test_support",
"//v8:v8_external_startup_data_assets",
]
« no previous file with comments | « chrome/browser/offline_pages/background_loader_offliner_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698